weighted least squares -> ace-experiments #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional method to learn! which gives a linear least squares solution to a UnivariateLinearProblem and CovariateLinearProblem with known noise variance (weights). This function still needs to be tested, which will be done in a future commit.
Julia does not support multiple dispatch on keyword arguments, so in the new method for learn!(), the variable "var" must be defined as a Vector of variance parameters for each data point. The line copy!(lb.beta, linear_problem.beta) is removed because it is redundant.
Standardizing naming convention for files under test directory
bring changes on clean-up-refactor into weighted-least-squares
I had previously (mistakenly) removed the line "copy!(lb.β, linear_problem.β)" thinking it was redundant, but it is necessary for copying the learned value of β from linear_problem::LinearProblem to lb::LinearBasisPotential.
Tests the learn!() function for linear problems in Learning/linear.jl. At this stage, it only tests the types/values of elements of a UnivariateLinearProblem.
Start to draft CovariateLinearProblem testes
…xisting with MLE-based learning.
…y include updated files.
…reserve tracking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.