cephfs: template update to support VGS for cephfs #4448
Conversation
Madhu-1
added
the
ci/skip/multi-arch-build
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
| @@ -148,6 +148,9 @@ spec: | |||
| - "--timeout={{ .Values.provisioner.timeout }}" | |||
| - "--leader-election=true" | |||
| - "--extra-create-metadata=true" | |||
| {{- if .Values.provisioner.snapshotter.enableVolumeGroupSnapshots }} | |||
There was a problem hiding this comment.
Sorry, missed here😅
| {{- if .Values.provisioner.snapshotter.enableVolumeGroupSnapshots }} | |
| {{- if .Values.provisioner.snapshotter.args.enableVolumeGroupSnapshots }} |
There was a problem hiding this comment.
missed to push these changes :(
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
| @@ -148,6 +148,9 @@ spec: | |||
| - "--timeout={{ .Values.provisioner.timeout }}" | |||
| - "--leader-election=true" | |||
| - "--extra-create-metadata=true" | |||
| {{- if .Values.provisioner.snapshotter.args.enableVolumeGroupSnapshots }} | |||
| - "--enable-volume-group-snapshots=true" | |||
There was a problem hiding this comment.
Maybe set it to false otherwise? When the external-snapshotter changes the default, it should not suddenly get enabled when it is expected to be disabled.
There was a problem hiding this comment.
Thanks @nixpanic updated code where user can specify what user wants for this flag
mergify
bot
dismissed
iPraveenParihar’s stale review
Pull request has been modified.
|
@Mergifyio rebase |
deployment changes to support VGS for cephfs. Signed-off-by: Madhu Rajanna <[email protected]>
tempalate changes for cephfs volumegroupsnapshot the default is set to false and user can set the value to true to get the support for VGS. Signed-off-by: Madhu Rajanna <[email protected]>
✅ Branch has been successfully rebased |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at e6d9139 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
This PR contains the template changes to support volumegroupsnapshot for cephFS.
update #4435