Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable object-map,exclusive-lock or use the storageClass imageFeatures for "-temp" cloned RBD volumes #4936

Open
dimm0 opened this issue Oct 30, 2024 · 4 comments
Labels
component/rbd Issues related to RBD good first issue Good for newcomers

Comments

@dimm0
Copy link

dimm0 commented Oct 30, 2024

Describe the feature you'd like to have

In

f := []string{librbd.FeatureNameLayering, librbd.FeatureNameDeepFlatten}
the features for -temp volumes are hard-coded to layering,flatten, making it impossible to do rbd du in that cluster. Would it be possible to take the list of features from CSI config the same way it'sfor regular images? Or also enable object-map,exclusive-lock for these?

What is the value to the end user? (why is it a priority?)

Be able to see rbd du for all images quickly

How would the end user gain value from having this feature?
Quick rbd du

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Oct 31, 2024

Describe the feature you'd like to have

In

f := []string{librbd.FeatureNameLayering, librbd.FeatureNameDeepFlatten}

the features for -temp volumes are hard-coded to layering,flatten, making it impossible to do rbd du in that cluster. Would it be possible to take the list of features from CSI config the same way it'sfor regular images? Or also enable object-map,exclusive-lock for these?

What is the value to the end user? (why is it a priority?)

Be able to see rbd du for all images quickly

How would the end user gain value from having this feature? Quick rbd du

As these are the default in RBD, this can also be changed to include those. @nixpanic @Rakshith-R any thoughts on this?

@Madhu-1 Madhu-1 added the good first issue Good for newcomers label Oct 31, 2024
@nixpanic
Copy link
Member

nixpanic commented Nov 1, 2024

My preference would be to add the options for the cloning process, but ideally not an other configuration parameter if we can avoid it.

Has it been confirmed that with those options rbd du is not blocked while cloning images?

@nixpanic nixpanic added the component/rbd Issues related to RBD label Nov 1, 2024
@dimm0
Copy link
Author

dimm0 commented Nov 1, 2024

It still seems slow but faster than without... I don't have enough knowledge about the snapshots to explain it.

@Rakshith-R
Copy link
Contributor

I think we should

  • In pvc-pvc clone case, use same imageFeatures for -temp image as the final one
  • In volumensnapshot case, inherit it from the parent image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rbd Issues related to RBD good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants