Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: recover tokens #1964

Merged
merged 8 commits into from
Aug 15, 2024
Merged

feat: recover tokens #1964

merged 8 commits into from
Aug 15, 2024

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Aug 13, 2024 •
edited
Loading

Description

  • Adds root extrinsic to initiate token recovery in EVM with UTs and IT
  • Minor improvements in LP inbound tests
  • Add schedule_upgrade and cancel_upgrade ITs

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@wischli wischli self-assigned this Aug 13, 2024
lemunozm
lemunozm reviewed Aug 13, 2024
View reviewed changes
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some questions

pallets/liquidity-pools/src/lib.rs Outdated Show resolved Hide resolved
pallets/liquidity-pools/src/mock.rs Show resolved Hide resolved
pallets/liquidity-pools/src/tests.rs Show resolved Hide resolved
pallets/liquidity-pools/src/tests/inbound.rs Outdated Show resolved Hide resolved
pallets/liquidity-pools/src/tests/inbound.rs Outdated Show resolved Hide resolved
@wischli wischli changed the title feat: fecover tokens feat: recover tokens Aug 14, 2024
@wischli wischli marked this pull request as ready for review August 14, 2024 04:48
@wischli wischli added D0-ready Pull request can be merged without special precaution and notification. I8-enhancement An additional feature. labels Aug 14, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 47.71%. Comparing base (0d29d17) to head (0902d96).
Report is 1 commits behind head on main.

Files Patch % Lines
pallets/liquidity-pools/src/lib.rs 83.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
+ Coverage   47.65%   47.71%   +0.06%     
==========================================
  Files         183      183              
  Lines       12906    12929      +23     
==========================================
+ Hits         6150     6169      +19     
- Misses       6756     6760       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wischli wischli requested a review from lemunozm August 15, 2024 07:18
lemunozm
lemunozm approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks William!

@lemunozm
Copy link
Contributor

Let's merge this!

@wischli wischli merged commit e8f1efd into main Aug 15, 2024
11 of 13 checks passed
@wischli wischli deleted the lp-v2/recover-tokens branch August 15, 2024 10:43
@wischli wischli mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemunozm lemunozm lemunozm approved these changes

Assignees

@wischli wischli

Labels
D0-ready Pull request can be merged without special precaution and notification. I8-enhancement An additional feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wischli @lemunozm