From b9a0914b807ae4501d630f28ddd475590df77aba Mon Sep 17 00:00:00 2001 From: lemunozm Date: Tue, 14 Nov 2023 12:44:06 +0100 Subject: [PATCH 1/4] test in debug --- ci/run-check.sh | 6 +++--- docs/DEVELOPING.md | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ci/run-check.sh b/ci/run-check.sh index f3fe6b094b..bc487c252f 100755 --- a/ci/run-check.sh +++ b/ci/run-check.sh @@ -10,15 +10,15 @@ cargo --version case $TARGET in cargo-build) - cargo build --release "$@" + cargo build "$@" ;; test-general) - cargo test --workspace --release --features runtime-benchmarks,try-runtime --exclude runtime-integration-tests + cargo test --workspace --features runtime-benchmarks,try-runtime --exclude runtime-integration-tests ;; test-integration) - cargo test --release --package runtime-integration-tests --features fast-runtime + cargo test --package runtime-integration-tests --features fast-runtime ;; lint-fmt) diff --git a/docs/DEVELOPING.md b/docs/DEVELOPING.md index fb5042790a..412784b0ea 100644 --- a/docs/DEVELOPING.md +++ b/docs/DEVELOPING.md @@ -28,7 +28,7 @@ and another one to verify how it works in a more real environment as a parachain The following command will run the unit and integration tests: ```bash -cargo +nightly test --workspace --release --features runtime-benchmarks,try-runtime +cargo test --workspace --features runtime-benchmarks,try-runtime ``` ### Environment tests @@ -84,7 +84,7 @@ You can play with it from the parachain client, make transfers, inspect events, ## Linting ### Source code -Lint the source code with `cargo +nightly fmt`. This excludes certain paths (defined in `rustfmt.toml`) that we want to stay as close as possible to `paritytech/substrate` to simplify upgrading to new releases. +Lint the source code with `cargo fmt`. This excludes certain paths (defined in `rustfmt.toml`) that we want to stay as close as possible to `paritytech/substrate` to simplify upgrading to new releases. ### Cargo.toml files 1. Install [taplo](https://github.com/tamasfe/taplo) with `cargo install taplo-cli`. From 5ad171187abfda4d7ed3dcdf7913b9f40d258729 Mon Sep 17 00:00:00 2001 From: lemunozm Date: Tue, 14 Nov 2023 14:03:43 +0100 Subject: [PATCH 2/4] TEMP reenable trigger --- .github/workflows/sanity-checks.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/sanity-checks.yml b/.github/workflows/sanity-checks.yml index c731405830..877ab01e1b 100644 --- a/.github/workflows/sanity-checks.yml +++ b/.github/workflows/sanity-checks.yml @@ -1,6 +1,6 @@ on: - # push: - # branches: [main, 'release-v**'] + push: + branches: ['ci-rewrite-n-cache'] pull_request: paths: - 'src/' @@ -42,12 +42,12 @@ jobs: # # make Cargo.toml # echo "Generate code coverage for ${{ matrix.target }}" # cargo +nightly tarpaulin --verbose --no-fail-fast --workspace --timeout 300 --out Xml - # fi + # fi - name: Runing cargo ${{ matrix.target }} run: ./ci/run-check.sh env: TARGET: ${{ matrix.target }} - RUSTC_WRAPPER: "sccache" + RUSTC_WRAPPER: "sccache" # UPLOAD REPORTS (requires cargo 1.70.0) # - name: Upload codecov report @@ -58,7 +58,7 @@ jobs: # # flags: unittests # optional # # name: codecov-umbrella # optional # # fail_ci_if_error: true # optional (default = false) - # verbose: true # optional (default = false) + # verbose: true # optional (default = false) benchmark-check: name: bench-check-${{ matrix.runtime }} From 53960e0c5492ce25f50e9864222f08093f1547fa Mon Sep 17 00:00:00 2001 From: lemunozm Date: Wed, 15 Nov 2023 12:09:19 +0100 Subject: [PATCH 3/4] reduce the log level to error --- .github/workflows/sanity-checks.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/sanity-checks.yml b/.github/workflows/sanity-checks.yml index 877ab01e1b..ea1c6d0664 100644 --- a/.github/workflows/sanity-checks.yml +++ b/.github/workflows/sanity-checks.yml @@ -81,6 +81,7 @@ jobs: - name: Runing cargo ${{ matrix.target }} run: ./ci/run-check.sh env: + RUST_LOG: ERROR TARGET: benchmark-check RUNTIME: ${{ matrix.runtime }} RUSTC_WRAPPER: "sccache" From 914bc93fdd114efa258ccda1720d90a1f4895c3a Mon Sep 17 00:00:00 2001 From: cdamian <17934949+cdamian@users.noreply.github.com> Date: Thu, 16 Nov 2023 12:01:31 +0100 Subject: [PATCH 4/4] integration-tests: Change default log level to ERROR --- runtime/integration-tests/src/utils/logs.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime/integration-tests/src/utils/logs.rs b/runtime/integration-tests/src/utils/logs.rs index fec9837e5a..4e583fc8e8 100644 --- a/runtime/integration-tests/src/utils/logs.rs +++ b/runtime/integration-tests/src/utils/logs.rs @@ -21,7 +21,7 @@ const UNINITIALIZED: usize = 0; const INITIALIZING: usize = 1; const INITIALIZED: usize = 2; -const LOG_LEVEL: LevelFilter = LevelFilter::INFO; +const LOG_LEVEL: LevelFilter = LevelFilter::ERROR; pub fn init_logs() { if GLOBAL_INIT