Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polkadot v1.1.0 #1605

Closed
wants to merge 5 commits into from
Closed

Polkadot v1.1.0 #1605

wants to merge 5 commits into from

Conversation

mustermeiszer
Copy link
Collaborator

@mustermeiszer mustermeiszer commented Nov 8, 2023

Description

[description]

Fixes #(issue)

Changes and Descriptions

Tasks

  • Update chainbridge to polkadot-v1.1.0
  • Update fudge to polkadot-v1.1.0
  • Decide on whether to go with moonbeam/frontier or paritytech/frontier
  • Check if eth_getLogs is fixed in this frontier version

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@mustermeiszer
Copy link
Collaborator Author

NOTE: We will keep this PR stale for as long as Polkadot is not upgrade to 1.1.0

@lemunozm
Copy link
Contributor

Before going with it, can I have time to finish #1609? The amount of breaking change would be really high, and I think migrating after #1609 makes things simpler, having fewer dependencies

@wischli
Copy link
Contributor

wischli commented Nov 20, 2023

Before going with it, can I have time to finish #1609? The amount of breaking change would be really high, and I think migrating after #1609 makes things simpler, having fewer dependencies

Given that Polkadot has not even upgraded to v1.0.0 yet (emergency stopped last week due to XCM bug noticed in Kusama), I don't think this PR needs attention before EOY.

@lemunozm
Copy link
Contributor

lemunozm commented Feb 16, 2024

  • Decide on whether to go with moonbeam/frontier or paritytech/frontier

@mustermeiszer, could you expand on this topic? Is it related to the 4th point?

@@ -0,0 +1,143 @@
// Copyright 2021 Centrifuge Foundation (centrifuge.io).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this file (and kusama) version come from? Is this required now we use the generic module?

@lemunozm
Copy link
Contributor

lemunozm commented Mar 1, 2024

I am closing this. I want to submit the new changes to the a branch with the same name, but I wish to conserve this PR diffs as a reference.

@lemunozm lemunozm closed this Mar 1, 2024
@lemunozm lemunozm deleted the polkadot-v1.1.0 branch March 1, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants