Loans: Integration tests #1600

lemunozm · 2023-10-26T13:12:39Z

Changes and Descriptions

Add main loan use cases (under generic/src/cases/loans.rs):
- Entire flow with internal priced loans
- Entire flow with external priced loans using oracles
- Mutating a loan through a pool change guard.
- ~~Check all kind of mutations based on different restriction.~~ This is blocked since there is no way to pass one week without burning the computer during 15-minute computing blocks.
  - One possibility is to mock the time, it means, pass a week in just one block. Although some state could not be "real" after this. Postpone for a future PR (related issue: Pallet-pool-registry: add test for write-off policy creation #1499)
Removed obsoleted loan integration tests and moved some env tests to their more related placed (most of the modified diff files come from this, sorry 🙏🏻).
Reorganize generic modules under integration tests to be more readable, now:

runtime/integration-tests/src/generic
├── cases               // Use cases go here
│  ├── example.rs
│  └── loans.rs
├── envs                // Environments go here
│  ├── fudge_env
│  │  └── handle.rs
│  ├── fudge_env.rs
│  └── runtime_env.rs
├── utils               // Generic utilities for any use case:
│  ├── currency.rs      // Easy support for interacting with currencies as ED or its decimals
│  ├── genesis.rs       // Generic support for initializing pallets
│  └── mod.rs
├── config.rs           // Where Runtime trait and other configs are defined.
├── env.rs              // Environment trait with basic defaults
├── impls.rs            // where runtimes implement the new traits
├── mod.rs
└── README.md

Fixes a bug in processing blocks BySeconds
Add Block::JumpBySeconds see comment

runtime/integration-tests/src/generic/impls.rs

runtime/integration-tests/src/utils/env.rs

runtime/integration-tests/src/utils/extrinsics.rs

runtime/integration-tests/src/generic/README.md

cdamian · 2023-10-26T13:38:32Z

I assume we want to get this in before the .43 update so we'll have to eventually get these changes in that branch.

lemunozm · 2023-10-26T14:45:47Z

Yes, and later, my idea is to create another "branch" where I update this over 9.43 before I leave and alleviate you from issues here. But I'm not sure if I'll get time!

lemunozm · 2023-10-26T17:37:11Z

runtime/integration-tests/src/generic/cases/example.rs

+fn pass_time_one_block<T: Runtime>() {
+	let mut env = RuntimeEnv::<T>::from_storage(Default::default());
+
+	let before = env.state(|| pallet_timestamp::Pallet::<T>::get());
+
+	// Not supported in fudge
+	env.pass(Blocks::JumpBySeconds(SECONDS_PER_YEAR));
+
+	let after = env.state(|| pallet_timestamp::Pallet::<T>::get());
+
+	assert_eq!((after - before).into_seconds(), SECONDS_PER_YEAR)
+}
+


@cdamian I need your fudge wisdom on this.

What I'm doing with the JumpBySeconds in the RuntimeEnv is jumping to a block in the future where it has passed SECONDS_PER_YEAR. This works quite well to "emulate" a state in the future, only creating one block. It's not as accurate as passing all blocks equivalent to a year, but it's much much faster and unlocks these tests for CI.

Do you think we can modify fudge to add this behavior, jumping to a block in the future without computing the intermediate blocks?

cc @mustermeiszer

Sorry for missing this. I don't think that will be feasible given our evolve logic, but I'm still lacking knowledge on the topic. @mustermeiszer Might know more.

lemunozm · 2023-10-27T14:24:27Z

Thanks for the approval @cdamian!

wischli

Shoot, I am a bit too late. Luckily, I only had non-blocking nitpicks. Great work @luis! Thanks so much for the README, it really helps!

wischli · 2023-10-27T13:56:47Z

runtime/integration-tests/src/generic/README.md

+
+You can choose the environment for each of your use cases:
+  - `RuntimeEnv`: Simple environment that acts as a wrapper over the runtime
+  - `FudgeEnv`: Advanced environment that use a client and connect the runtime to a relay chain.


Nit:

Suggested change

- `FudgeEnv`: Advanced environment that use a client and connect the runtime to a relay chain.

- `FudgeEnv`: Advanced environment that uses a client and connects the runtime to a relay chain.

wischli · 2023-10-27T13:57:11Z

runtime/integration-tests/src/generic/README.md

+  - `RuntimeEnv`: Simple environment that acts as a wrapper over the runtime
+  - `FudgeEnv`: Advanced environment that use a client and connect the runtime to a relay chain.
+
+Both environment uses the same interface so jumping from one to the another should be something "smooth".


Nit

Suggested change

Both environment uses the same interface so jumping from one to the another should be something "smooth".

Both environment use the same interface, so jumping from one to the another should be somewhat "smooth".

wischli · 2023-10-27T14:02:38Z

runtime/integration-tests/src/generic/README.md

+
+Both environment uses the same interface so jumping from one to the another should be something "smooth".
+
+## Where I start?


Nit

Suggested change

## Where I start?

## Where do I start?

wischli · 2023-10-27T14:06:08Z

runtime/integration-tests/src/generic/cases/loans.rs

@@ -42,112 +47,323 @@ use crate::{
 const POOL_ADMIN: Keyring = Keyring::Admin;
 const INVESTOR: Keyring = Keyring::Alice;
 const BORROWER: Keyring = Keyring::Bob;
+const LOAN_ADMIN: Keyring = Keyring::Charlie;
+const ANY: Keyring = Keyring::Dave;


Nit: We should make it clear this refers to a substrate address

Suggested change

const ANY: Keyring = Keyring::Dave;

const ANYONE: Keyring = Keyring::Dave;

lemunozm · 2023-10-27T14:49:18Z

Written down as doc-debt! 😆
Thanks for the corrections!

lemunozm added I4-tests Test needs fixing or improving. P5-soon Issue should be addressed soon. I6-refactoring Code needs refactoring. labels Oct 26, 2023

lemunozm requested a review from hieronx October 26, 2023 13:12

lemunozm self-assigned this Oct 26, 2023

lemunozm requested review from mustermeiszer, NunoAlexandre, wischli and cdamian as code owners October 26, 2023 13:12

cdamian reviewed Oct 26, 2023

View reviewed changes

runtime/integration-tests/src/generic/impls.rs Show resolved Hide resolved

cdamian reviewed Oct 26, 2023

View reviewed changes

runtime/integration-tests/src/utils/env.rs Show resolved Hide resolved

cdamian reviewed Oct 26, 2023

View reviewed changes

runtime/integration-tests/src/utils/extrinsics.rs Show resolved Hide resolved

cdamian reviewed Oct 26, 2023

View reviewed changes

runtime/integration-tests/src/generic/README.md Outdated Show resolved Hide resolved

lemunozm force-pushed the loans/integration-tests branch from e3842cc to 573a2d7 Compare October 26, 2023 17:33

lemunozm commented Oct 26, 2023

View reviewed changes

lemunozm added 11 commits October 26, 2023 20:09

finish basic_loan_flow

dada23c

remove deprecated tests

0ea63aa

reorganization of the generic module

fb0c847

add Readme

693d9e3

support for external priced loans

f8be6d8

oracle example working

eff5303

refactor using calls

c434bf7

add maturity extension changed test

d699e1c

minor doc fixes

4ab6412

fix block by seconds issue

5b264e0

Support jumping to future blocks

83a5095

lemunozm force-pushed the loans/integration-tests branch from 573a2d7 to 83a5095 Compare October 26, 2023 18:09

Merge remote-tracking branch 'origin/main' into loans/integration-tests

8fc7858

cdamian approved these changes Oct 27, 2023

View reviewed changes

lemunozm merged commit f46d327 into main Oct 27, 2023
10 checks passed

wischli reviewed Oct 27, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Loans: Integration tests #1600

Loans: Integration tests #1600

lemunozm commented Oct 26, 2023 •

edited

Loading

cdamian commented Oct 26, 2023

lemunozm commented Oct 26, 2023

lemunozm Oct 26, 2023

cdamian Oct 27, 2023

lemunozm commented Oct 27, 2023

wischli left a comment

wischli Oct 27, 2023

wischli Oct 27, 2023

wischli Oct 27, 2023

wischli Oct 27, 2023

lemunozm commented Oct 27, 2023

	- `FudgeEnv`: Advanced environment that use a client and connect the runtime to a relay chain.
	- `FudgeEnv`: Advanced environment that uses a client and connects the runtime to a relay chain.

	Both environment uses the same interface so jumping from one to the another should be something "smooth".
	Both environment use the same interface, so jumping from one to the another should be somewhat "smooth".


		Both environment uses the same interface so jumping from one to the another should be something "smooth".

		## Where I start?

	const ANY: Keyring = Keyring::Dave;
	const ANYONE: Keyring = Keyring::Dave;

Loans: Integration tests #1600

Loans: Integration tests #1600

Conversation

lemunozm commented Oct 26, 2023 • edited Loading

Changes and Descriptions

cdamian commented Oct 26, 2023

lemunozm commented Oct 26, 2023

lemunozm Oct 26, 2023

Choose a reason for hiding this comment

cdamian Oct 27, 2023

Choose a reason for hiding this comment

lemunozm commented Oct 27, 2023

wischli left a comment

Choose a reason for hiding this comment

wischli Oct 27, 2023

Choose a reason for hiding this comment

wischli Oct 27, 2023

Choose a reason for hiding this comment

wischli Oct 27, 2023

Choose a reason for hiding this comment

wischli Oct 27, 2023

Choose a reason for hiding this comment

lemunozm commented Oct 27, 2023

lemunozm commented Oct 26, 2023 •

edited

Loading