Add HTTP response code to ErrorEvent #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vyndor many thanks! Do you plan to change the endpoint by re-instantiating client? Or we need a method for that? |
Yes, I create new instance of Client with new endpoint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add HTTP response code to ErrorEvent.
There is an alternative approach to this PR.
In my opinion it would be better to pass whole response to ErrorEvent, but it will expose okhttp in centrifuge API.
Why our project needs this
Our project needs an ability to change an endpoint in case of specific errors:
HTTP status codes currently does not exposed by centrifuge SDK, so we do not know when we need to change endpoint.