Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

signalling server doesn't reload cert file when it's updated, requires a manual restart #58

Open
thbaja opened this issue Nov 8, 2018 · 3 comments

Comments

@thbaja
Copy link

thbaja commented Nov 8, 2018

for https://webrtc.nirbheek.in:8443

@tp-m
Copy link
Contributor

tp-m commented Nov 8, 2018

cc @nirbheek

@nirbheek
Copy link
Contributor

nirbheek commented Nov 8, 2018

Oof. The same old problem where when the certificate gets updated, the signalling server doesn't reload the cert file. I've restarted the server, but this should be fixed. Updating issue name.

@nirbheek nirbheek changed the title Certificate expired today signalling server doesn't reload cert file when it's updated, requires a manual restart Nov 8, 2018
@nirbheek
Copy link
Contributor

nirbheek commented Nov 9, 2018

Well, I tried the suggestion in https://stackoverflow.com/a/43875481 to re-instantiate the asyncio server, but it didn't really work (ssl connections started just failing after the reload). Going to try and investigate that a bit more and if it doesn't work, will just implement a restart + inotify behind an option.

Most production deployments I know of put the signalling server behind an nginx proxy anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants