Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move outline-go-tun2socks to a git submodule #215

Closed
ignoramous opened this issue Jan 2, 2021 · 2 comments
Closed

Move outline-go-tun2socks to a git submodule #215

ignoramous opened this issue Jan 2, 2021 · 2 comments

Comments

@ignoramous
Copy link
Collaborator

2. Move `outline-go-tun2socks` in as a `git submodule`.

Would having a monorepo (subfolder/module for tun2socks) also be fine for you? That would be simpler and we could just depend on it using pure gradle (and wouldn't have to init/pull the submodule all the time).
I'm not sure whether Android projects can have non-Android modules though.

We are going to include WireGuard in this project at some point, too: Prefer that it comes in as a git-module. I am mostly basing it off of on how Orchid handles external but critical (security sensitive) cross langauge deps: https://github.com/OrchidTechnologies/orchid/blob/master/.gitmodules

I take, your concern is that gradle process won't be straight-forward? That is, Android Studio build integration would be convoluted more than necessary?

Originally posted by @ignoramous in #212 (comment)

@ignoramous ignoramous mentioned this issue Feb 15, 2021
@michaelblyons
Copy link

michaelblyons commented Feb 15, 2021

You guys are going to add WireGuard? 🤩 (Edit: it's #52)

@ignoramous
Copy link
Collaborator Author

git submodules plan is defunct because a couple of folks scared me from using it.

Instead, the go-dependencies for RethinkDNS are built from source and published as an Android Archive (firestack.aar) to jitpack.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants