Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent app from crashing in dev mode when yaml has undefined values #178

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

nicolasbrugneaux
Copy link
Contributor

Also replace the handcrafted yaml parser by gray-matter

[Closes #176]

…lues

Also replace the handcrafted yaml parser
[Closes #176]
@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staked-celo-web-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 9:42am

@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
gray-matter 4.0.3 eval, filesystem +9 846 kB rmassaioli

@github-actions
Copy link

📦 Next.js Bundle Analysis for staked-celo-app

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

@yerdua yerdua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from a stray debugging console.log statement, this looks good to go.

src/features/governance/data/getProposals.ts Outdated Show resolved Hide resolved
@nicolasbrugneaux nicolasbrugneaux merged commit 7355956 into main Sep 20, 2023
4 checks passed
@nicolasbrugneaux nicolasbrugneaux deleted the fix/yaml-parsing branch September 20, 2023 09:42
@github-actions
Copy link

📦 Next.js Bundle Analysis for staked-celo-app

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate failing parsing YAML on local dev environment
2 participants