Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User cannot close account modal when clicking "X" button #167

Closed
arthurgousset opened this issue Sep 6, 2023 · 0 comments · Fixed by #173
Closed

User cannot close account modal when clicking "X" button #167

arthurgousset opened this issue Sep 6, 2023 · 0 comments · Fixed by #173

Comments

@arthurgousset
Copy link
Contributor

arthurgousset commented Sep 6, 2023 •
edited
Loading

Environment
Operating System: macOS 13.5.1
Chrome browser: Version 116.0.5845.140
stCelo version: Can't find version (but last commit on main is f13e722)
Wallet: Safe wallet (app.safe.global) connected using WalletConnect

Describe the bug
User cannot close "account" modal when clicking "X" button

To Reproduce
Steps to reproduce the behavior:

  1. Go to app.stcelo.xyz

  2. Click on the address

  3. "Account" modal opens up

  4. Click "X" button (top right)

  5. Modal doesn't close

See recording

Screen.Recording.2023-09-06.at.15.03.00.mov

Expected behavior
When clicking X, the modal should close.

Current work around: Clicking anywhere outside the modal closes the modal.
@arthurgousset arthurgousset changed the title User cannot close account modal with "X" button User cannot close account modal when clicking "X" button Sep 6, 2023
nicolasbrugneaux added a commit that referenced this issue Sep 14, 2023
@nicolasbrugneaux
fix: clicking the X button closes the modal
97aa1ca 
[Closes #167]
@nicolasbrugneaux nicolasbrugneaux mentioned this issue Sep 15, 2023
Merged
nicolasbrugneaux added a commit that referenced this issue Sep 15, 2023
@nicolasbrugneaux
Feat/voting balance improvements (#173)
a112664 
* fix: show the modal when clicking the button and restyle it to make it more obvious

* fix: clicking the X button closes the modal

[Closes #167]

* feat: add funds disclaimer

* fix: only show the disclaimer while unstaking
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/voting balance improvements celo-org/staked-celo-web-app
1 participant
@arthurgousset