Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Failure while deploying token #278

Closed
palango opened this issue Nov 29, 2024 · 0 comments · Fixed by #281
Closed

e2e: Failure while deploying token #278

palango opened this issue Nov 29, 2024 · 0 comments · Fixed by #281
Assignees
@karlb

Comments

@palango
Copy link

palango commented Nov 29, 2024

Seen in https://app.circleci.com/pipelines/github/celo-org/optimism/2092/workflows/291f01b3-8b98-4b49-892a-a51b29f8d9fa/jobs/43280

++ jq .deployedTo -r
+ L1_WETH=null
++ cast send --private-key ac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80 0x4200000000000000000000000000000000000012 'createOptimismMintableERC20(address,string,string)' null 'Wrapped Ether' WETH --json
++ jq -r '.logs[0].topics[2]'
++ cast parse-bytes32-address
Error: parser error:
null
^
expected hex digits or the `0x` prefix for an empty hex string

Context:
- parser error:
null
^
expected hex digits or the `0x` prefix for an empty hex string
Error: expected 64 byte hex-string, got 
+ L2_TOKEN=
@karlb karlb self-assigned this Dec 6, 2024
karlb added a commit that referenced this issue Dec 6, 2024
@karlb
e2e: use --broadcast with forge create
c1fe7f1 
Forge started to require the `--broadcast` flag for actually deploying a
contract. Otherwise it will only do a dry-run.

We should really pin our foundry version. But let's wait until we rebase
to the latest upstream, since there have been changes to the overall
setup.

Closes #278
@karlb karlb mentioned this issue Dec 6, 2024
Merged
@karlb karlb closed this as completed in #281 Dec 9, 2024
@karlb karlb closed this as completed in 4bd372a Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karlb karlb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

e2e: use --broadcast with forge create celo-org/optimism
2 participants
@palango @karlb