-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI Proposal View Regression #7
Comments
And the annoying thing is that because celocli has the @celo/governance dependency specified as ^5.0.4, even if I install an older (3.0.1) version of the cli it still will pull 5.0.6 as the governance package and have parallelization. We should probably pin internal dependencies :( |
It would be fantastic to get a fix released quickly, as we want to issue a proposal on Monday at the latest. The fast solution now would be to roll back the parallelization of parsing and release. After that, I'm happy to help figure out a long term solution. What comes to mind is grouping all proxy updates into a batch, executing those, and then parallelising the rest. |
ill work on this this afternoon. |
Thanks so much <3 |
we cant just roll back the entire commit as this fixed issue where there are so many proposals that it just stopped working , but ill work on the parsing each proposal sequentially |
@aaronmgdr this introduces a regression. As part of a proposal sometimes you want to update a proxy to a new implementation and call a method on that new implementation. This is done internally by keeping a mapping of updated implementations when they are found, but this requires a proposal to be parsed sequentially.
Originally posted by @bowd in celo-org/celo-monorepo#10652 (comment)
The text was updated successfully, but these errors were encountered: