Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

investigate multi derivation path lookups (celo, eth, x ledger variations) #448

Open
Tracked by #358
aaronmgdr opened this issue Nov 18, 2024 · 4 comments
Open
Tracked by #358
Assignees

Comments

@aaronmgdr
Copy link
Member

aaronmgdr commented Nov 18, 2024

before making eth default in #352

we should work on making it so that ledger/signers will search in 4 places, celo derivation, eth derivation, celo ledger derivation, eth ledger derivation.

behaviors

  1. when a --from is passed while using --useLedger search thru multi derivation paths
  2. add aliases for celo-legacy where derivationPath is a flag
  3. add command for setting default celocli config:set --derivationPath eth|celo-legacy|string
  4. when using ledger allow celo-legacy-ledger and eth-ledger derivations paths
@aaronmgdr aaronmgdr added this to the 5 - Celo MVP Mainnet milestone Nov 18, 2024
@aaronmgdr aaronmgdr self-assigned this Nov 18, 2024
@aaronmgdr
Copy link
Member Author

or maybe flag for ledger-live and just dual search celo and eth paths

@aaronmgdr
Copy link
Member Author

more thoughts

we use derivation path in 2 ways but they are not really connected as they should not ever share a mnemonic. account:new and when using --useLedger.

account:new doesn't need to use ledgerLive mode. but it would be nice to use the same accounts on celocli as we do on ledger live when using --useLedger option.

@aaronmgdr
Copy link
Member Author

should ledgerLiveMode be a derivationpath or a new flag?

the reason for a new flag is that its still the same base derivation path but how its iterated changes from position 5 to position 4 iteration.

using derivationPath alias would require special behavior for ledger live derivation paths.

where as a new flag could be used with the paths for more possibilities would with few lines of code.

@aaronmgdr
Copy link
Member Author

on account:list with --useLedger rather than just LedgerAddresses show

eth derivation
celo legacy derivation
celo legacy ledger live derivation

sets of addreses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant