[WIP- do not merge] CR10 -> master #10647
Conversation
* Revert "Fix dequeueProposalIfReady() for expired proposals. (#10324)" This reverts commit 890d195. * Revert "Update upvode function (#10268)" This reverts commit ce75f49. * ReleaseGold refund test fix (#10440) * ReleaseGold refund test fix * gas fix * Pahor/cli fix2 (#10457) * ReleaseGold refund test fix * gas fix * PR comments * removal of comment * Cli fix 2 * Running GitHub Action workflow from release/* branches * Fix regex * Trigger protocol tests on release branches * add logging * lint fix * uniswap test fix * Trigger Identity tests too --------- Co-authored-by: Javier Cortejoso <[email protected]>
* Update of config to core-contract v9 * buildable * buildable * Buildable and with everything agreed on * lockedgold tests * tests added for 2 delegators * lockedgold tests done * removeVotesWhenRevokingDelegatedVotes tests start * removeVotesWhenRevokingDelegatedVotes for one proposal working * removeVotesWhenRevokingDelegatedVotes tests added * Test fixes * final tests * Natspec + refactor * Versions update * Update packages/protocol/contracts/governance/LockedGold.sol Co-authored-by: Edwin <[email protected]> * Update packages/protocol/test/governance/voting/lockedgold.ts Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test/governance/voting/lockedgold.ts Co-authored-by: soloseng <[email protected]> * Update packages/protocol/contracts/governance/LockedGold.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/contracts/governance/LockedGold.sol Co-authored-by: soloseng <[email protected]> * Update packages/protocol/test/governance/voting/lockedgold.ts Co-authored-by: soloseng <[email protected]> * PR comments * lint * Restrict delegatee count * Locked Gold update * Added tests * Artifacts singleton moved to make quicktest work again * lint fix * version update * SafeMath + delegator fix * more tests * lint * prettier * Safe math * Safe math * PR comments * Rounding error during removal * revoke during unlock * Validators cannot delegate * tests fixes * PR comments * validators update * added tests * fixidity but tests not fully working yet * Audit critical fixes * comment updates * test fix * Auditor comments * validators update * locked gold fix * Debug Protocol Release tests * Debug Protocol test release. Adding traces * Unbounded var --------- Co-authored-by: Edwin <[email protected]> Co-authored-by: soloseng <[email protected]> Co-authored-by: Javier Cortejoso <[email protected]>
* handle and distribute only active tokens * Correctly burn Celo * removal of redundant check * AMBIGUOUS LOGIC FOR MAX SLIPPAGE IN FEEHANDLERSELLER * REDUNDANT LINE AND HANDLER CHECK IN FEEHANDLER * UNUSED EVENTS * Update packages/protocol/contracts/common/FeeHandler.sol Co-authored-by: soloseng <[email protected]> * build fix * dont handle removed tokens * PR comments * Removed TODO --------- Co-authored-by: Martín Volpe <[email protected]> Co-authored-by: soloseng <[email protected]>
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat's wrong with native code?Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs. Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
🦋 Changeset detectedLatest commit: a7f18d0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Closed to merge #10690 instead |
Description
A few sentences describing the overall effects and goals of the pull request's commits.
What is the current behavior, and what is the updated/expected behavior with this PR?
Other changes
Describe any minor or "drive-by" changes here.
Tested
An explanation of how the changes were tested or an explanation as to why they don't need to be.
Related issues
Backwards compatibility
Brief explanation of why these changes are/are not backwards compatible.
Documentation
The set of community facing docs that have been added/modified because of this change