Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt CI test to UltraGreen CIP-52 changes #10403

Closed
wants to merge 2 commits into from

Conversation

karlb
Copy link
Contributor

@karlb karlb commented Jun 27, 2023

Transferring the fees to the FeeHandler instead of the Governance contract requires update in the CI tests.

This should be part of the UltraGreen changes, but requires a celo-blockchain version including celo-org/celo-blockchain#2049 (thus the current CI failures for governance and transfers).

@karlb karlb requested a review from martinvol June 27, 2023 12:42
@karlb karlb marked this pull request as ready for review June 28, 2023 08:02
@karlb karlb requested a review from a team as a code owner June 28, 2023 08:02
@karlb karlb requested a review from alvarof2 June 28, 2023 08:02
@karlb karlb force-pushed the karlb/ultragreen-ci-tests branch from 5ec8e5a to 88e98c3 Compare June 28, 2023 08:05
Base automatically changed from martinvol/ultraGreen to release/core-contracts/10 June 29, 2023 13:48
@martinvol martinvol requested a review from a team as a code owner June 29, 2023 13:48
@martinvol martinvol requested a review from a team June 29, 2023 13:48
@martinvol martinvol requested a review from a team as a code owner June 29, 2023 13:48
@karlb karlb force-pushed the karlb/ultragreen-ci-tests branch 2 times, most recently from 42cbbd7 to d021065 Compare July 3, 2023 08:10
@arthurgousset
Copy link
Contributor

Quick check-in: Is there a reason this PR is still open after @carterqw2's approval?

@karlb
Copy link
Contributor Author

karlb commented Sep 29, 2023

There are still CI failures preventing merging this PR. Does anyone know what the problem is, or should I take a look?

@karlb
Copy link
Contributor Author

karlb commented Oct 2, 2023

  70) Transfer tests
       Transfer with Demurrage >
         lightest Node >
           when there is demurrage of 50% applied
             when setting a gas amount greater than the amount of gas necessary
               should halve the FeeHandler's Celo Dollar balance then increment it by the base portion of the gas fees:

      AssertionError: expected '0' to equal '7100000000000'
      + expected - actual

      -0
      +7100000000000

Isn't demurrage/stability fee remove? Why do we still have tests for this?

@karlb karlb force-pushed the karlb/ultragreen-ci-tests branch from dd67b13 to 96fa724 Compare November 10, 2023 07:17
@karlb karlb requested review from a team November 10, 2023 07:17
@karlb karlb requested a review from a team as a code owner November 10, 2023 07:17
@karlb karlb requested a review from a team November 10, 2023 07:17
Copy link

changeset-bot bot commented Nov 10, 2023

⚠️ No Changeset found

Latest commit: d59d95e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

socket-security bot commented Nov 10, 2023

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@karlb karlb force-pushed the karlb/ultragreen-ci-tests branch from 96fa724 to 1825f20 Compare November 10, 2023 08:10
@karlb karlb changed the base branch from release/core-contracts/10 to master November 10, 2023 10:09
@karlb karlb force-pushed the karlb/ultragreen-ci-tests branch from 1825f20 to 6571420 Compare November 10, 2023 10:10
@karlb karlb force-pushed the karlb/ultragreen-ci-tests branch from 6571420 to d59d95e Compare November 11, 2023 08:46
@karlb
Copy link
Contributor Author

karlb commented Nov 14, 2023

Since contracts v10 have been merged to master and master is green, these changes seem not to be necessary, anymore.

@karlb karlb closed this Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants