-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt CI test to UltraGreen CIP-52 changes #10403
Conversation
5ec8e5a
to
88e98c3
Compare
42cbbd7
to
d021065
Compare
d021065
to
dd67b13
Compare
Quick check-in: Is there a reason this PR is still open after @carterqw2's approval? |
There are still CI failures preventing merging this PR. Does anyone know what the problem is, or should I take a look? |
Isn't demurrage/stability fee remove? Why do we still have tests for this? |
dd67b13
to
96fa724
Compare
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
96fa724
to
1825f20
Compare
1825f20
to
6571420
Compare
6571420
to
d59d95e
Compare
Since contracts v10 have been merged to master and master is green, these changes seem not to be necessary, anymore. |
Transferring the fees to the FeeHandler instead of the Governance contract requires update in the CI tests.
This should be part of the UltraGreen changes, but requires a celo-blockchain version including celo-org/celo-blockchain#2049 (thus the current CI failures for governance and transfers).