Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dappkit deprecation #10207

Closed
nicolasbrugneaux opened this issue Mar 1, 2023 · 10 comments
Closed

dappkit deprecation #10207

nicolasbrugneaux opened this issue Mar 1, 2023 · 10 comments
Assignees
Labels
cleanup javascript Pull requests that update Javascript code question

Comments

@nicolasbrugneaux
Copy link
Contributor

nicolasbrugneaux commented Mar 1, 2023

Following this convo:

Hello there, the topic of "moving the core-contract types so they can more easily be imported in typescript" has come up again during the apptooling meeting and we're gonna try to separate into their own package. The only question is whether to move them to a different package or even outside of the monorepo.

The current trend seems to be to cleanup the monorepo a bit, but having the types stay here actually makes tons of sense (no tooling to reinvent, no submodules to handle)

Any thoughts?

@nicolasbrugneaux nicolasbrugneaux added cleanup javascript Pull requests that update Javascript code question labels Mar 1, 2023
@nicolasbrugneaux nicolasbrugneaux self-assigned this Mar 1, 2023
@nicolasbrugneaux
Copy link
Contributor Author

Tagging @celo-org/default-owners

@arthurgousset
Copy link
Contributor

arthurgousset commented Mar 6, 2023

Reflecting discussion from weekly sync:

  • We agreed the scope here is less to make a new package and more
    • to understand the uses of contractkit within cLabs (CLI, primitive team release, identity SDK, etc)
    • to understand the packages used in contractkit
    • fully map out the dependencies of contractkit and if they are used standalone
    • to understand who cares if we propose to sunset contractkit for the public (the goal is not to sunset per se, but to find out who needs contractkit and why)
    • get rid of dappkit??

Note:

  • We already know contractkit is often necessary in conjunction with the gas fee currency feature

@nicolasbrugneaux
Copy link
Contributor Author

WIP findings https://www.notion.so/clabsco/WIP-celo-contractkit-830cce5acffe4d65bbe9a61724364f63, I will keep updating that doc as I gather more info

@nicolasbrugneaux
Copy link
Contributor Author

Scheduled a call with Valora which seems to be the only users of dappkit to talk about sunsetting

@nicolasbrugneaux
Copy link
Contributor Author

Dappkit sunsetting post https://forum.celo.org/t/sunsetting-dappkit/5336

@nicolasbrugneaux
Copy link
Contributor Author

nicolasbrugneaux commented Mar 15, 2023

Contractkit public sunsetting post https://forum.celo.org/t/sunsetting-contractkit/5337

@nicolasbrugneaux
Copy link
Contributor Author

nicolasbrugneaux commented Mar 15, 2023

Todo following the two blog posts:

  • make a migration guide from contrackit
  • set a deprecation notice for contractkit in npm (by Wed, Mar 22)
  • start killing dappkit (by Wed, Mar 22)
    • add a deprecation notice on npm
    • remove the package from the monorepo

Context:

  • You can't delete code from npm once it's been downloaded. But you can set a deprecation notice.

@arthurgousset
Copy link
Contributor

arthurgousset commented Mar 15, 2023

@nicolasbrugneaux nicolasbrugneaux changed the title Move core-contract types to their own package or to their own repo [Meta] dappkit - contractkit deprecation Mar 15, 2023
@nicolasbrugneaux
Copy link
Contributor Author

Migration guide

Removal of dappkit

@arthurgousset arthurgousset changed the title [Meta] dappkit - contractkit deprecation [Meta] dappkit & contractkit deprecation Mar 29, 2023
@arthurgousset arthurgousset changed the title [Meta] dappkit - contractkit deprecation [Meta] dappkit & contractkit deprecation Mar 29, 2023
@nicolasbrugneaux
Copy link
Contributor Author

Closing this and following issue specific to contractkit can be found here: #10289

@nicolasbrugneaux nicolasbrugneaux changed the title [Meta] dappkit & contractkit deprecation dappkit deprecation May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup javascript Pull requests that update Javascript code question
Projects
None yet
Development

No branches or pull requests

2 participants