Bug in proposal passing threshold

[aaronmgdr]

Description

proposal #189:
mondo.celo.org shows needing 7,326,086 CELO to pass quorum
whereas celo.stake.id and celocli on show needing 4,395,652.

info

because of the complexity of dermining what passing means relies on a number of factors including params for what is changing by proposal, the number of votes last few referenda. etc. it is very difficult to get this right. the code used by the contract is not exposed which means we must re implement it.

Ideally we would make an upgrade to governance.sol but that seems unlikely.

Alternative solution could be just just call isPassing function and if is true assume that one is correct. t

[aaronmgdr]

more examples

[nicolasbrugneaux]

additionally: ask a correct spec for the calculation, currently needs to read the core contract and mimic the implementation