Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dependabot #21

Closed
rootulp opened this issue Jan 17, 2024 · 8 comments
Closed

Enable dependabot #21

rootulp opened this issue Jan 17, 2024 · 8 comments
Assignees

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jan 17, 2024

Context

go 1.21.5

Problem

It looks like dependabot isn't enabled on this repo because it uses Go 1.21.5 but Go 1.21.6 has been released

Acceptance Criteria

Enable dependabot

@rootulp
Copy link
Collaborator Author

rootulp commented May 27, 2024

I'm blocked b/c I don't have permission to see the settings on this repo.

@MSevey can you please give me admin or maintainer permissions on this repo?

@cristaloleg
Copy link
Contributor

Why do we need to bump Go version in go.mod ?

Also, dependabot doesn't support that iirc.

@rootulp
Copy link
Collaborator Author

rootulp commented May 27, 2024

I think you're right b/c celestia-app has dependabot enabled and we've had to manually bump Go versions. But I think it's still a good idea to enable dependabot on this repo to bump the Go deps even though there aren't many.

@cristaloleg
Copy link
Contributor

No-no, I'm about another thing which is not dependabot related: what is the reason to bump Go version in go.mod at all?

@rootulp
Copy link
Collaborator Author

rootulp commented May 27, 2024

So that we can use features from new Go releases.

@cristaloleg
Copy link
Contributor

Fair enough. The only thing why I started this dialogue is that I saw go.mod bumps only when they are reaaaally needed. Also, Go patch releases don't give any language changes.

@MSevey
Copy link
Member

MSevey commented May 28, 2024

I'm blocked b/c I don't have permission to see the settings on this repo.

@MSevey can you please give me admin or maintainer permissions on this repo?

done

@rootulp
Copy link
Collaborator Author

rootulp commented May 29, 2024

Dependabot was already enabled. I confirmed the config file looks good.

Screenshot

Screenshot 2024-05-29 at 11 05 30 AM

@rootulp rootulp closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants