Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(p2p): Observe length of peerTracker tracked and disconnected #145

Open
renaynay opened this issue Jan 22, 2024 · 0 comments
Open

fix(p2p): Observe length of peerTracker tracked and disconnected #145

renaynay opened this issue Jan 22, 2024 · 0 comments
Assignees
Labels

Comments

@renaynay
Copy link
Member

It is easier to understand peerTracker health if we make the observe callback directly look at the length of the map at the time of observation rather than observing the ints that are on the exchangeMetrics struct as it's not clear when the peerTracker has X many tracked vs disconnected peers.

Let's instead take the length of the maps directly (rlocking of course), but this will make the metric more understandable.

cc @distractedm1nd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants