Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/blob): fix namespace parsing in cli #4003

Merged
merged 1 commit into from
Dec 12, 2024
Merged

fix(cmd/blob): fix namespace parsing in cli #4003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions nodebuilder/blob/cmd/blob.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,11 @@ var getCmd = &cobra.Command{
Short: "Returns the blob for the given namespace by commitment at a particular height.\n" +
"Note:\n* Both namespace and commitment input parameters are expected to be in their hex representation.",
PreRunE: func(_ *cobra.Command, args []string) error {
if !strings.HasPrefix(args[1], "0x") {
return fmt.Errorf("only hex namespace is supported")
if !strings.HasPrefix(args[0], "0x") {
args[0] = "0x" + args[0]
}
if !strings.HasPrefix(args[2], "0x") {
return fmt.Errorf("only hex commitment is supported")
if !strings.HasPrefix(args[1], "0x") {
args[1] = "0x" + args[1]
}
return nil
},
Expand Down Expand Up @@ -84,8 +84,11 @@ var getAllCmd = &cobra.Command{
Short: "Returns all blobs for the given namespace at a particular height.\n" +
"Note:\n* Namespace input parameter is expected to be in its hex representation.",
PreRunE: func(_ *cobra.Command, args []string) error {
if !strings.HasPrefix(args[0], "0x") {
args[0] = "0x" + args[0]
}
if !strings.HasPrefix(args[1], "0x") {
return fmt.Errorf("only hex namespace is supported")
args[1] = "0x" + args[1]
}
return nil
},
Expand Down Expand Up @@ -136,7 +139,10 @@ var submitCmd = &cobra.Command{
},
PreRunE: func(_ *cobra.Command, args []string) error {
if !strings.HasPrefix(args[0], "0x") {
return fmt.Errorf("only hex namespace is supported")
args[0] = "0x" + args[0]
}
if !strings.HasPrefix(args[1], "0x") {
args[1] = "0x" + args[1]
}
return nil
},
Expand Down Expand Up @@ -235,11 +241,11 @@ var getProofCmd = &cobra.Command{
Short: "Retrieves the blob in the given namespaces at the given height by commitment and returns its Proof.\n" +
"Note:\n* Both namespace and commitment input parameters are expected to be in their hex representation.",
PreRunE: func(_ *cobra.Command, args []string) error {
if !strings.HasPrefix(args[1], "0x") {
return fmt.Errorf("only hex namespace is supported")
if !strings.HasPrefix(args[0], "0x") {
args[0] = "0x" + args[0]
}
if !strings.HasPrefix(args[2], "0x") {
return fmt.Errorf("only hex commitment is supported")
if !strings.HasPrefix(args[1], "0x") {
args[1] = "0x" + args[1]
}
return nil
},
Expand Down
Loading