Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull based catchup #1522

Closed
evan-forbes opened this issue Oct 31, 2024 · 2 comments
Closed

Pull based catchup #1522

evan-forbes opened this issue Oct 31, 2024 · 2 comments
Assignees
Labels
Compact Blocks WS: Big Blonks 🔭 Improving consensus critical gossiping protocols

Comments

@evan-forbes
Copy link
Member

Currently, nodes will send catchup block data if they don't receive state updates from peers. This aggressive catchup routine is very error prone, because state messages are far from instant. Especially when the network is congested and state messages take longer to be received. Not only that, but if the peer is actually behind due to congestion, the congestion will only get worse as all of their peers will each send them block data.

Instead, nodes should request data from specific peers when they notice they are behind.

While slightly more conservative, it should significantly improve congestion.

This is related to the other efforts for faster recovery and compact blocks #1334

@evan-forbes evan-forbes added WS: Big Blonks 🔭 Improving consensus critical gossiping protocols Compact Blocks labels Oct 31, 2024
@evan-forbes evan-forbes self-assigned this Nov 11, 2024
@cmwaters
Copy link
Contributor

cmwaters commented Nov 13, 2024

Will this pull-based block part mechanism also replace block propagation or just catchup?

Also will this use optimistic haves (i.e. starling)?

@evan-forbes
Copy link
Member Author

closing in favor of #1532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compact Blocks WS: Big Blonks 🔭 Improving consensus critical gossiping protocols
Projects
None yet
Development

No branches or pull requests

2 participants