From 4f26e6affe86a88eff7c63024df10525131af186 Mon Sep 17 00:00:00 2001 From: Rootul Patel Date: Mon, 25 Nov 2024 16:29:17 -0500 Subject: [PATCH 1/9] docs(specs): add missing versioned consts --- pkg/appconsts/v1/app_consts.go | 14 ++++++++++---- pkg/appconsts/v2/app_consts.go | 7 +++++-- pkg/appconsts/v3/app_consts.go | 2 +- specs/src/parameters_v1.md | 9 +++++---- specs/src/parameters_v2.md | 11 ++++++----- specs/src/parameters_v3.md | 18 +++++++++++------- 6 files changed, 38 insertions(+), 23 deletions(-) diff --git a/pkg/appconsts/v1/app_consts.go b/pkg/appconsts/v1/app_consts.go index 873d3ec18a..fee33747e3 100644 --- a/pkg/appconsts/v1/app_consts.go +++ b/pkg/appconsts/v1/app_consts.go @@ -6,10 +6,16 @@ const ( Version uint64 = 1 SquareSizeUpperBound int = 128 SubtreeRootThreshold int = 64 - TimeoutPropose = time.Second * 10 - TimeoutCommit = time.Second * 11 + // Note: TimeoutPropose and TimeoutCommit weren't actually constants in v1, + // they were defaults for user-configurable timeouts. TODO: consider + // removing them from this package. + TimeoutPropose = time.Second * 10 + TimeoutCommit = time.Second * 11 // UpgradeHeightDelay is the number of blocks after a quorum has been - // reached that the chain should upgrade to the new version. Assuming a block - // interval of 12 seconds, this is 7 days. + // reached that the chain should upgrade to the new version. Assuming a + // block interval of 12 seconds, this is 7 days. + // + // TODO: why does this constant exist in v1? v1 does not contain the signal + // module. UpgradeHeightDelay = int64(7 * 24 * 60 * 60 / 12) // 7 days * 24 hours * 60 minutes * 60 seconds / 12 seconds per block = 50,400 blocks. ) diff --git a/pkg/appconsts/v2/app_consts.go b/pkg/appconsts/v2/app_consts.go index d02a97079b..78d6603668 100644 --- a/pkg/appconsts/v2/app_consts.go +++ b/pkg/appconsts/v2/app_consts.go @@ -6,8 +6,11 @@ const ( Version uint64 = 2 SquareSizeUpperBound int = 128 SubtreeRootThreshold int = 64 - TimeoutPropose = time.Second * 10 - TimeoutCommit = time.Second * 11 + // Note: TimeoutPropose and TimeoutCommit weren't actually constants in v1, + // they were defaults for user-configurable timeouts. TODO: consider + // removing them from this package. + TimeoutPropose = time.Second * 10 + TimeoutCommit = time.Second * 11 // UpgradeHeightDelay is the number of blocks after a quorum has been // reached that the chain should upgrade to the new version. Assuming a block // interval of 12 seconds, this is 7 days. diff --git a/pkg/appconsts/v3/app_consts.go b/pkg/appconsts/v3/app_consts.go index 3f9279518d..e5b660bf2e 100644 --- a/pkg/appconsts/v3/app_consts.go +++ b/pkg/appconsts/v3/app_consts.go @@ -13,6 +13,6 @@ const ( TimeoutCommit = time.Millisecond * 4200 // UpgradeHeightDelay is the number of blocks after a quorum has been // reached that the chain should upgrade to the new version. Assuming a block - // interval of 12 seconds, this is 7 days. + // interval of 6 seconds, this is 7 days. UpgradeHeightDelay = int64(7 * 24 * 60 * 60 / 6) // 7 days * 24 hours * 60 minutes * 60 seconds / 6 seconds per block = 100,800 blocks. ) diff --git a/specs/src/parameters_v1.md b/specs/src/parameters_v1.md index 436b8cb471..ff95bd47b6 100644 --- a/specs/src/parameters_v1.md +++ b/specs/src/parameters_v1.md @@ -8,10 +8,11 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. ## Global parameters -| Parameter | Default | Summary | Changeable via Governance | -|-------------------|---------|------------------------------------------------------------------------------------------------------------------------|---------------------------| -| MaxBlockSizeBytes | 100MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | -| MaxSquareSize | 128 | Hardcoded maximum square size determined per shares per row or column for the original data square (not yet extended). | False | +| Parameter | Value | Summary | Changeable via Governance | +|----------------------|---------|------------------------------------------------------------------------------------------------------------------------------------|---------------------------| +| SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | +| SubtreeRootThreshold | 64 | See ADR 13 for more details. | False | +| MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | ## Module parameters diff --git a/specs/src/parameters_v2.md b/specs/src/parameters_v2.md index ec93c9acda..a9b258f965 100644 --- a/specs/src/parameters_v2.md +++ b/specs/src/parameters_v2.md @@ -8,11 +8,12 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. ## Global parameters -| Parameter | Default | Summary | Changeable via Governance | -|--------------------|---------|------------------------------------------------------------------------------------------------------------------------|---------------------------| -| MaxBlockSizeBytes | 100MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | -| MaxSquareSize | 128 | Hardcoded maximum square size determined per shares per row or column for the original data square (not yet extended). | False | -| UpgradeHeightDelay | 50400 | Height based delay after a successful `MsgTryUpgrade` has been submitted. | False | +| Parameter | Value | Summary | Changeable via Governance | +|----------------------|--------------|------------------------------------------------------------------------------------------------------------------------------------|---------------------------| +| SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | +| SubtreeRootThreshold | 64 | See ADR 13 for more details. | False | +| UpgradeHeightDelay | 50400 blocks | Height based delay after a successful `MsgTryUpgrade` has been submitted. | False | +| MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | ## Module parameters diff --git a/specs/src/parameters_v3.md b/specs/src/parameters_v3.md index 6f8d84fccb..c2912afb3d 100644 --- a/specs/src/parameters_v3.md +++ b/specs/src/parameters_v3.md @@ -8,11 +8,15 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. ## Global parameters -| Parameter | Default | Summary | Changeable via Governance | -|--------------------|---------|------------------------------------------------------------------------------------------------------------------------|---------------------------| -| MaxBlockSizeBytes | 100MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | -| MaxSquareSize | 128 | Hardcoded maximum square size determined per shares per row or column for the original data square (not yet extended). | False | -| UpgradeHeightDelay | 100800 | Height based delay after a successful `MsgTryUpgrade` has been submitted. | False | +| Parameter | Value | Summary | Changeable via Governance | +|----------------------|---------------|------------------------------------------------------------------------------------------------------------------------------------|---------------------------| +| SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | +| SubtreeRootThreshold | 64 | See ADR 13 for more details. | False | +| MaxTxSize | 2 MiB | Maximum size of a transaction in bytes. | False | +| TimeoutPropose | 3500 ms | Specifies the time that validators wait during the proposal phase of the consensus process. See CometBFT specs for more details. | False | +| TimeoutCommit | 4200 ms | Specifies the duration that validators wait during the Commit phase of the consensus process. See CometBFT specs for more details. | False | +| UpgradeHeightDelay | 100800 blocks | Height based delay after a successful `MsgTryUpgrade` has been submitted. | False | +| MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | ## Module parameters @@ -22,9 +26,9 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. | auth.SigVerifyCostED25519 | 590 | Gas used to verify Ed25519 signature. | True | | auth.SigVerifyCostSecp256k1 | 1000 | Gas used to verify secp256k1 signature. | True | | auth.TxSigLimit | 7 | Max number of signatures allowed in a multisig transaction. | True | -| auth.TxSizeCostPerByte | 10 | Gas used per transaction byte. | False | +| auth.TxSizeCostPerByte | 10 | Gas used per transaction byte. | False | | bank.SendEnabled | true | Allow transfers. | False | -| blob.GasPerBlobByte | 8 | Gas used per blob byte. | False | +| blob.GasPerBlobByte | 8 | Gas used per blob byte. | False | | blob.GovMaxSquareSize | 64 | Governance parameter for the maximum square size of the original data square. | True | | consensus.block.MaxBytes | 1974272 bytes (~1.88 MiB) | Governance parameter for the maximum size of the protobuf encoded block. | True | | consensus.block.MaxGas | -1 | Maximum gas allowed per block (-1 is infinite). | True | From be6a63a1917dffbae0743a287455b17fdade0399 Mon Sep 17 00:00:00 2001 From: Rootul P Date: Tue, 26 Nov 2024 16:42:08 -0500 Subject: [PATCH 2/9] Update specs/src/parameters_v1.md Co-authored-by: CHAMI Rachid --- specs/src/parameters_v1.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/src/parameters_v1.md b/specs/src/parameters_v1.md index ff95bd47b6..ae74a4cbbe 100644 --- a/specs/src/parameters_v1.md +++ b/specs/src/parameters_v1.md @@ -11,7 +11,7 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. | Parameter | Value | Summary | Changeable via Governance | |----------------------|---------|------------------------------------------------------------------------------------------------------------------------------------|---------------------------| | SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | -| SubtreeRootThreshold | 64 | See ADR 13 for more details. | False | +| SubtreeRootThreshold | 64 | See [ADR-013](https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md) for more details. | False | | MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | ## Module parameters From e97e996df3061654604cdefaa5540128d768ef24 Mon Sep 17 00:00:00 2001 From: Rootul P Date: Tue, 26 Nov 2024 16:42:13 -0500 Subject: [PATCH 3/9] Update specs/src/parameters_v2.md Co-authored-by: CHAMI Rachid --- specs/src/parameters_v2.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/src/parameters_v2.md b/specs/src/parameters_v2.md index a9b258f965..9379bc6e69 100644 --- a/specs/src/parameters_v2.md +++ b/specs/src/parameters_v2.md @@ -11,7 +11,7 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. | Parameter | Value | Summary | Changeable via Governance | |----------------------|--------------|------------------------------------------------------------------------------------------------------------------------------------|---------------------------| | SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | -| SubtreeRootThreshold | 64 | See ADR 13 for more details. | False | +| SubtreeRootThreshold | 64 | See [ADR-013](https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md) for more details. | False | | UpgradeHeightDelay | 50400 blocks | Height based delay after a successful `MsgTryUpgrade` has been submitted. | False | | MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | From 9d87c1eed64ad5047a83caea46d2cf89266eb113 Mon Sep 17 00:00:00 2001 From: Rootul P Date: Tue, 26 Nov 2024 16:42:17 -0500 Subject: [PATCH 4/9] Update specs/src/parameters_v3.md Co-authored-by: CHAMI Rachid --- specs/src/parameters_v3.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/src/parameters_v3.md b/specs/src/parameters_v3.md index c2912afb3d..037ccdf5d0 100644 --- a/specs/src/parameters_v3.md +++ b/specs/src/parameters_v3.md @@ -11,7 +11,7 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. | Parameter | Value | Summary | Changeable via Governance | |----------------------|---------------|------------------------------------------------------------------------------------------------------------------------------------|---------------------------| | SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | -| SubtreeRootThreshold | 64 | See ADR 13 for more details. | False | +| SubtreeRootThreshold | 64 | See [ADR-013](https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md) for more details. | False | | MaxTxSize | 2 MiB | Maximum size of a transaction in bytes. | False | | TimeoutPropose | 3500 ms | Specifies the time that validators wait during the proposal phase of the consensus process. See CometBFT specs for more details. | False | | TimeoutCommit | 4200 ms | Specifies the duration that validators wait during the Commit phase of the consensus process. See CometBFT specs for more details. | False | From bace6533a2c120314c97d4783b7917fe8c03c5f4 Mon Sep 17 00:00:00 2001 From: Rootul P Date: Tue, 26 Nov 2024 16:42:39 -0500 Subject: [PATCH 5/9] Update specs/src/parameters_v3.md Co-authored-by: CHAMI Rachid --- specs/src/parameters_v3.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/src/parameters_v3.md b/specs/src/parameters_v3.md index 037ccdf5d0..59fe53bb60 100644 --- a/specs/src/parameters_v3.md +++ b/specs/src/parameters_v3.md @@ -14,7 +14,7 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. | SubtreeRootThreshold | 64 | See [ADR-013](https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md) for more details. | False | | MaxTxSize | 2 MiB | Maximum size of a transaction in bytes. | False | | TimeoutPropose | 3500 ms | Specifies the time that validators wait during the proposal phase of the consensus process. See CometBFT specs for more details. | False | -| TimeoutCommit | 4200 ms | Specifies the duration that validators wait during the Commit phase of the consensus process. See CometBFT specs for more details. | False | +| TimeoutCommit | 4200 ms | Specifies the duration that validators wait during the Commit phase of the consensus process. See CometBFT [specs](https://github.com/celestiaorg/celestia-core/blob/v0.34.x-celestia/spec/consensus/consensus.md#precommit-step-heighthroundr) for more details. | False | | UpgradeHeightDelay | 100800 blocks | Height based delay after a successful `MsgTryUpgrade` has been submitted. | False | | MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | From 77053b762b91e681e087096778376424ad177e20 Mon Sep 17 00:00:00 2001 From: Rootul P Date: Tue, 26 Nov 2024 16:42:44 -0500 Subject: [PATCH 6/9] Update specs/src/parameters_v3.md Co-authored-by: CHAMI Rachid --- specs/src/parameters_v3.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/specs/src/parameters_v3.md b/specs/src/parameters_v3.md index 59fe53bb60..9e70d70654 100644 --- a/specs/src/parameters_v3.md +++ b/specs/src/parameters_v3.md @@ -13,7 +13,7 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. | SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | | SubtreeRootThreshold | 64 | See [ADR-013](https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md) for more details. | False | | MaxTxSize | 2 MiB | Maximum size of a transaction in bytes. | False | -| TimeoutPropose | 3500 ms | Specifies the time that validators wait during the proposal phase of the consensus process. See CometBFT specs for more details. | False | +| TimeoutPropose | 3500 ms | Specifies the time that validators wait during the proposal phase of the consensus process. See CometBFT [specs](https://github.com/celestiaorg/celestia-core/blob/v0.34.x-celestia/spec/consensus/consensus.md#propose-step-heighthroundr) for more details. | False | | TimeoutCommit | 4200 ms | Specifies the duration that validators wait during the Commit phase of the consensus process. See CometBFT [specs](https://github.com/celestiaorg/celestia-core/blob/v0.34.x-celestia/spec/consensus/consensus.md#precommit-step-heighthroundr) for more details. | False | | UpgradeHeightDelay | 100800 blocks | Height based delay after a successful `MsgTryUpgrade` has been submitted. | False | | MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | From 39f26441c099ffefcc3144b5d35914506e127105 Mon Sep 17 00:00:00 2001 From: Rootul Patel Date: Tue, 26 Nov 2024 16:45:18 -0500 Subject: [PATCH 7/9] improve comments --- pkg/appconsts/v1/app_consts.go | 9 +++++---- pkg/appconsts/v2/app_consts.go | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/pkg/appconsts/v1/app_consts.go b/pkg/appconsts/v1/app_consts.go index fee33747e3..1a3890bedc 100644 --- a/pkg/appconsts/v1/app_consts.go +++ b/pkg/appconsts/v1/app_consts.go @@ -6,11 +6,12 @@ const ( Version uint64 = 1 SquareSizeUpperBound int = 128 SubtreeRootThreshold int = 64 - // Note: TimeoutPropose and TimeoutCommit weren't actually constants in v1, - // they were defaults for user-configurable timeouts. TODO: consider - // removing them from this package. + // TimeoutPropose wasn't a constant in v1, it was the default for a + // user-configurable timeout. TimeoutPropose = time.Second * 10 - TimeoutCommit = time.Second * 11 + // TimeoutCommit wasn't a constant in v1, it was the default for a + // user-configurable timeout. + TimeoutCommit = time.Second * 11 // UpgradeHeightDelay is the number of blocks after a quorum has been // reached that the chain should upgrade to the new version. Assuming a // block interval of 12 seconds, this is 7 days. diff --git a/pkg/appconsts/v2/app_consts.go b/pkg/appconsts/v2/app_consts.go index 78d6603668..cd574af755 100644 --- a/pkg/appconsts/v2/app_consts.go +++ b/pkg/appconsts/v2/app_consts.go @@ -6,11 +6,12 @@ const ( Version uint64 = 2 SquareSizeUpperBound int = 128 SubtreeRootThreshold int = 64 - // Note: TimeoutPropose and TimeoutCommit weren't actually constants in v1, - // they were defaults for user-configurable timeouts. TODO: consider - // removing them from this package. + // TimeoutPropose wasn't a constant in v2, it was the default for a + // user-configurable timeout. TimeoutPropose = time.Second * 10 - TimeoutCommit = time.Second * 11 + // TimeoutCommit wasn't a constant in v2, it was the default for a + // user-configurable timeout. + TimeoutCommit = time.Second * 11 // UpgradeHeightDelay is the number of blocks after a quorum has been // reached that the chain should upgrade to the new version. Assuming a block // interval of 12 seconds, this is 7 days. From 879a42732c2ffa19ee7e32fb33d2284bc57a7642 Mon Sep 17 00:00:00 2001 From: Rootul Patel Date: Tue, 26 Nov 2024 16:46:00 -0500 Subject: [PATCH 8/9] prettify tables --- specs/src/parameters_v1.md | 10 +++++----- specs/src/parameters_v2.md | 12 ++++++------ specs/src/parameters_v3.md | 16 ++++++++-------- 3 files changed, 19 insertions(+), 19 deletions(-) diff --git a/specs/src/parameters_v1.md b/specs/src/parameters_v1.md index ae74a4cbbe..5bfdd1eee1 100644 --- a/specs/src/parameters_v1.md +++ b/specs/src/parameters_v1.md @@ -8,11 +8,11 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. ## Global parameters -| Parameter | Value | Summary | Changeable via Governance | -|----------------------|---------|------------------------------------------------------------------------------------------------------------------------------------|---------------------------| -| SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | -| SubtreeRootThreshold | 64 | See [ADR-013](https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md) for more details. | False | -| MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | +| Parameter | Value | Summary | Changeable via Governance | +|----------------------|---------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------| +| SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | +| SubtreeRootThreshold | 64 | See [ADR-013](https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md) for more details. | False | +| MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | ## Module parameters diff --git a/specs/src/parameters_v2.md b/specs/src/parameters_v2.md index 9379bc6e69..411e4c0778 100644 --- a/specs/src/parameters_v2.md +++ b/specs/src/parameters_v2.md @@ -8,12 +8,12 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. ## Global parameters -| Parameter | Value | Summary | Changeable via Governance | -|----------------------|--------------|------------------------------------------------------------------------------------------------------------------------------------|---------------------------| -| SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | -| SubtreeRootThreshold | 64 | See [ADR-013](https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md) for more details. | False | -| UpgradeHeightDelay | 50400 blocks | Height based delay after a successful `MsgTryUpgrade` has been submitted. | False | -| MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | +| Parameter | Value | Summary | Changeable via Governance | +|----------------------|--------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------| +| SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | +| SubtreeRootThreshold | 64 | See [ADR-013](https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md) for more details. | False | +| UpgradeHeightDelay | 50400 blocks | Height based delay after a successful `MsgTryUpgrade` has been submitted. | False | +| MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | ## Module parameters diff --git a/specs/src/parameters_v3.md b/specs/src/parameters_v3.md index 9e70d70654..40c043c576 100644 --- a/specs/src/parameters_v3.md +++ b/specs/src/parameters_v3.md @@ -8,15 +8,15 @@ hardcoded in the application or they are blocked by the `x/paramfilter` module. ## Global parameters -| Parameter | Value | Summary | Changeable via Governance | -|----------------------|---------------|------------------------------------------------------------------------------------------------------------------------------------|---------------------------| -| SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | -| SubtreeRootThreshold | 64 | See [ADR-013](https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md) for more details. | False | -| MaxTxSize | 2 MiB | Maximum size of a transaction in bytes. | False | -| TimeoutPropose | 3500 ms | Specifies the time that validators wait during the proposal phase of the consensus process. See CometBFT [specs](https://github.com/celestiaorg/celestia-core/blob/v0.34.x-celestia/spec/consensus/consensus.md#propose-step-heighthroundr) for more details. | False | +| Parameter | Value | Summary | Changeable via Governance | +|----------------------|---------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------| +| SquareSizeUpperBound | 128 | Hardcoded maximum square size which limits the number of shares per row or column for the original data square (not yet extended). | False | +| SubtreeRootThreshold | 64 | See [ADR-013](https://github.com/celestiaorg/celestia-app/blob/main/docs/architecture/adr-013-non-interactive-default-rules-for-zero-padding.md) for more details. | False | +| MaxTxSize | 2 MiB | Maximum size of a transaction in bytes. | False | +| TimeoutPropose | 3500 ms | Specifies the time that validators wait during the proposal phase of the consensus process. See CometBFT [specs](https://github.com/celestiaorg/celestia-core/blob/v0.34.x-celestia/spec/consensus/consensus.md#propose-step-heighthroundr) for more details. | False | | TimeoutCommit | 4200 ms | Specifies the duration that validators wait during the Commit phase of the consensus process. See CometBFT [specs](https://github.com/celestiaorg/celestia-core/blob/v0.34.x-celestia/spec/consensus/consensus.md#precommit-step-heighthroundr) for more details. | False | -| UpgradeHeightDelay | 100800 blocks | Height based delay after a successful `MsgTryUpgrade` has been submitted. | False | -| MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | +| UpgradeHeightDelay | 100800 blocks | Height based delay after a successful `MsgTryUpgrade` has been submitted. | False | +| MaxBlockSizeBytes | 100 MiB | Hardcoded value in CometBFT for the protobuf encoded block. | False | ## Module parameters From c5a916d4806e881803d1183d2a639835f619d430 Mon Sep 17 00:00:00 2001 From: Rootul Patel Date: Wed, 27 Nov 2024 09:56:14 -0500 Subject: [PATCH 9/9] deprecate consts --- pkg/appconsts/v1/app_consts.go | 16 ++++++---------- pkg/appconsts/v2/app_consts.go | 8 ++++---- 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/pkg/appconsts/v1/app_consts.go b/pkg/appconsts/v1/app_consts.go index 1a3890bedc..478ce6ac3e 100644 --- a/pkg/appconsts/v1/app_consts.go +++ b/pkg/appconsts/v1/app_consts.go @@ -6,17 +6,13 @@ const ( Version uint64 = 1 SquareSizeUpperBound int = 128 SubtreeRootThreshold int = 64 - // TimeoutPropose wasn't a constant in v1, it was the default for a - // user-configurable timeout. + // TimeoutPropose is deprecated because it was not a constant + // in v1, it was the default for a user-configurable timeout. TimeoutPropose = time.Second * 10 - // TimeoutCommit wasn't a constant in v1, it was the default for a - // user-configurable timeout. + // TimeoutCommit is deprecated because it was not a constant + // in v1, it was the default for a user-configurable timeout. TimeoutCommit = time.Second * 11 - // UpgradeHeightDelay is the number of blocks after a quorum has been - // reached that the chain should upgrade to the new version. Assuming a - // block interval of 12 seconds, this is 7 days. - // - // TODO: why does this constant exist in v1? v1 does not contain the signal - // module. + // UpgradeHeightDelay is deprecated because v1 does not contain the signal + // module so this constant should not be used. UpgradeHeightDelay = int64(7 * 24 * 60 * 60 / 12) // 7 days * 24 hours * 60 minutes * 60 seconds / 12 seconds per block = 50,400 blocks. ) diff --git a/pkg/appconsts/v2/app_consts.go b/pkg/appconsts/v2/app_consts.go index cd574af755..b2e187eaf0 100644 --- a/pkg/appconsts/v2/app_consts.go +++ b/pkg/appconsts/v2/app_consts.go @@ -6,11 +6,11 @@ const ( Version uint64 = 2 SquareSizeUpperBound int = 128 SubtreeRootThreshold int = 64 - // TimeoutPropose wasn't a constant in v2, it was the default for a - // user-configurable timeout. + // TimeoutPropose is deprecated because it was not a constant + // in v2, it was the default for a user-configurable timeout. TimeoutPropose = time.Second * 10 - // TimeoutCommit wasn't a constant in v2, it was the default for a - // user-configurable timeout. + // TimeoutCommit is deprecated because it was not a constant + // in v2, it was the default for a user-configurable timeout. TimeoutCommit = time.Second * 11 // UpgradeHeightDelay is the number of blocks after a quorum has been // reached that the chain should upgrade to the new version. Assuming a block