Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: voting period on Mocha is incorrect #104

Open
rootulp opened this issue Nov 27, 2024 · 0 comments
Open

Bug: voting period on Mocha is incorrect #104

rootulp opened this issue Nov 27, 2024 · 0 comments

Comments

@rootulp
Copy link

rootulp commented Nov 27, 2024

Problem

The value reporting for voting period is incorrect for Mocha

Repro steps

  1. Navigate to https://mocha-4.celenium.io/
  2. Click Constants in sidebar
  3. See incorrect value for voting period (see screenshot below). It currently reports 172800s which is 48 hours. But the actual value is 86400000000000 nanoseconds which is 24 hours.
$ grpcurl -d '{"subspace": "gov", "key": "votingparams"}' celestia-mocha-grpc.publicnode.com:443 cosmos.params.v1beta1.Query/Params
{
  "param": {
    "subspace": "gov",
    "key": "votingparams",
    "value": "{\"voting_period\":\"86400000000000\"}"
  }
}

Screenshot

Screenshot 2024-11-27 at 3 53 27 PM

Feedback

  1. The text says nanoseconds but the value shows the unit "s" for seconds. IMO you could make it super readable for end-users by showing "1 day" or "24 hours" instead of the nanosecond or second value.
  2. The sidebar name "Constants" is slightly misleading because a lot of these values can be changed via governance. See https://celestiaorg.github.io/celestia-app/parameters_v3.html. One option is to rename it from "constants" to "parameters"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant