Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify all gets to return None if no values present in Redis #336

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

whabanks
Copy link
Contributor

Summary | Résumé

This PR unifies the return types of all get methods so they return None if keys or fields are not found. It also improves method docstrings to clarify parameter data formats when using ambiguous data structures.

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

Tests pass, release, tag, and test integration in Admin and API.

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

- Improve documentation, clarifying arbitrary data formats
Copy link
Member

@andrewleith andrewleith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one spelling issue!

notifications_utils/clients/redis/redis_client.py Outdated Show resolved Hide resolved
@whabanks whabanks merged commit b344e5a into main Nov 14, 2024
4 checks passed
@whabanks whabanks deleted the task/unify-annual-limit-client-return-types branch November 14, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants