From cd7b7b3dd121c93593c7fa74e8fbb3367179dccd Mon Sep 17 00:00:00 2001 From: Stephen Astels Date: Tue, 3 Sep 2024 13:31:44 -0400 Subject: [PATCH 1/2] remove optional unit param --- aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_alarms.tf | 2 -- 1 file changed, 2 deletions(-) diff --git a/aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_alarms.tf b/aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_alarms.tf index 221bf39a8..0fb1be755 100644 --- a/aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_alarms.tf +++ b/aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_alarms.tf @@ -178,7 +178,6 @@ resource "aws_cloudwatch_metric_alarm" "pinpoint-sms-success-rate-warning" { namespace = aws_cloudwatch_log_metric_filter.pinpoint-sms-successes[0].metric_transformation[0].namespace period = 60 * 60 * 12 stat = "Sum" - unit = "Count" } } @@ -189,7 +188,6 @@ resource "aws_cloudwatch_metric_alarm" "pinpoint-sms-success-rate-warning" { namespace = aws_cloudwatch_log_metric_filter.pinpoint-sms-failures[0].metric_transformation[0].namespace period = 60 * 60 * 12 stat = "Sum" - unit = "Count" } } } From b9c4c66342ccd0bba28a7a8189b62b039d280782 Mon Sep 17 00:00:00 2001 From: Stephen Astels Date: Tue, 3 Sep 2024 13:53:58 -0400 Subject: [PATCH 2/2] fix more alarms --- aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_alarms.tf | 6 ------ 1 file changed, 6 deletions(-) diff --git a/aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_alarms.tf b/aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_alarms.tf index 0fb1be755..89c830f5c 100644 --- a/aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_alarms.tf +++ b/aws/pinpoint_to_sqs_sms_callbacks/cloudwatch_alarms.tf @@ -97,7 +97,6 @@ resource "aws_cloudwatch_metric_alarm" "total-sms-spending-warning" { namespace = "AWS/SNS" period = 300 stat = "Maximum" - unit = "Count" } } @@ -108,7 +107,6 @@ resource "aws_cloudwatch_metric_alarm" "total-sms-spending-warning" { namespace = "AWS/SMSVoice" period = 300 stat = "Maximum" - unit = "Count" } } } @@ -137,7 +135,6 @@ resource "aws_cloudwatch_metric_alarm" "total-sms-spending-critical" { namespace = "AWS/SNS" period = 300 stat = "Maximum" - unit = "Count" } } @@ -148,7 +145,6 @@ resource "aws_cloudwatch_metric_alarm" "total-sms-spending-critical" { namespace = "AWS/SMSVoice" period = 300 stat = "Maximum" - unit = "Count" } } } @@ -218,7 +214,6 @@ resource "aws_cloudwatch_metric_alarm" "pinpoint-sms-success-rate-critical" { namespace = aws_cloudwatch_log_metric_filter.pinpoint-sms-successes[0].metric_transformation[0].namespace period = 60 * 60 * 12 stat = "Sum" - unit = "Count" } } @@ -229,7 +224,6 @@ resource "aws_cloudwatch_metric_alarm" "pinpoint-sms-success-rate-critical" { namespace = aws_cloudwatch_log_metric_filter.pinpoint-sms-failures[0].metric_transformation[0].namespace period = 60 * 60 * 12 stat = "Sum" - unit = "Count" } } }