Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the bearer token optional for API callbacks #849

Open
5 tasks
jimleroyer opened this issue Sep 8, 2022 · 0 comments
Open
5 tasks

Make the bearer token optional for API callbacks #849

jimleroyer opened this issue Sep 8, 2022 · 0 comments

Comments

@jimleroyer
Copy link
Member

Description

As a user of Notify,
I want the bearer token from the API callback to be optional,
So that I can leverage my Azure SAS authentication without getting impeded by the bearer token authentication.

WHY are we building?

To support authentication use cases that only requires the URL and no bearer token necessary.

WHAT are we building?

Making the bearer token field optional in the UI, the database and the application's model.

VALUE created by our solution

More authentication mechanism supported by Notify.

Redflags

Potentially, that might make some users not use a bearer tokens when they should. That will not minimize security from Notify side though as this is user's responsibility to protect their endpoints.

Acceptance Criteria** (Definition of done)

  • The bearer token is now optional in the UI.
  • The bearer token is now optional in the database.
  • Unit tests cover the new scenario.

QA Steps

Additional info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants