Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: TemplateCategory Backend Backfill #1587

Closed
6 tasks done
jzbahrai opened this issue Jun 4, 2024 · 4 comments
Closed
6 tasks done

Dev: TemplateCategory Backend Backfill #1587

jzbahrai opened this issue Jun 4, 2024 · 4 comments
Assignees
Labels
Dev Task for implementation of a technical solution

Comments

@jzbahrai
Copy link
Collaborator

jzbahrai commented Jun 4, 2024

Description

As a user I want to have a TemplateCategory Table in the backend and read the priority from them as a default.

Acceptance Criteria

  • Add 3 default categories into the TemplateCategory table (LowDefault, MediumDefault, HighDefault)
  • process_type on "Templates" table - drop Required constraint.
  • Write and execute the following script:
    Template that have process_type -> "priority", should map to TemplateCategory HighDefault.
    process_type -> "normal", map to "MediumDefault"
    process_type -> "low", map to "LowDefault"
  • Look through the API code and see where process_type is called-> instead of Template.process_type we should be calling Template.process_type if Template.process_type is NOT empty, else it is Template.TemplateCategory.process_type (SQLAlchemy relationship types - look at User.password - ADD TESTS)
  • Set all the process_type in the Template table to be None (ONLY after all the above steps are complete)
  • Add tests for the above

By the end of implementing the above, a Template process_type will come from the TemplateCategories table unless the process_type in the Template table is filled in.

@jzbahrai
Copy link
Collaborator Author

jzbahrai commented Jun 4, 2024

Hey team! Please add your planning poker estimate with Zenhub @andrewleith @whabanks

@jzbahrai jzbahrai changed the title Dev: Implement TemplateCategory Backend Dev: TemplateCategory Backend Backfill Jun 5, 2024
@yaelberger-commits yaelberger-commits added the Dev Task for implementation of a technical solution label Jun 10, 2024
@yaelberger-commits
Copy link
Collaborator

@andrewleith @whabanks @jzbahrai please add your estimates for this card

@whabanks
Copy link

whabanks commented Jun 25, 2024

These AC were completed as part of this PR.
Related card

  • Add 3 default categories into the TemplateCategory table (LowDefault, MediumDefault, HighDefault)
  • process_type on "Templates" table - drop Required constraint.
    - Look through the API code and see where process_type is called-> instead of Template.process_type we should be calling Template.process_type if Template.process_type is NOT empty, else it is

@yaelberger-commits
Copy link
Collaborator

Estimates please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev Task for implementation of a technical solution
Projects
None yet
Development

No branches or pull requests

3 participants