Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up unused email / sms delivery queues #209

Closed
6 tasks done
sastels opened this issue Oct 11, 2023 · 9 comments
Closed
6 tasks done

clean up unused email / sms delivery queues #209

sastels opened this issue Oct 11, 2023 · 9 comments
Assignees

Comments

@sastels
Copy link

sastels commented Oct 11, 2023

Description

As a developer, I need to clean up unused code.

WHY are we building?

Clean up unused code related to the now unused send-email-tasks and send-sms-tasks queues.

WHAT are we building?

Delete alarms, variables, and dashboard widgets related to these queues. Also delete code from the api repo related to these queues.

VALUE created by our solution

Less unused code / alarms / dashboards

Acceptance Criteria

Given some context, when (X) action occurs, then (Y) outcome is achieved.

  • Verify that send-sms-tasks and send-email-tasks are no longer being used
  • Alarms / dashboard widgets / variables are deleted from the terraform repo
  • Related code in config.py (api repo) is deleted

QA Steps

  • code deleted
  • no alarms go off
  • Test the 3 priorities in staging
@sastels sastels self-assigned this Mar 25, 2024
@sastels
Copy link
Author

sastels commented Mar 25, 2024

PR to remove queues from api / celery
cds-snc/notification-api#2148

@sastels
Copy link
Author

sastels commented Mar 26, 2024

send-email-tasks, zero usage in production last month:

image.png

send-sms-tasks, zero usage in production last month:
image.png

@sastels
Copy link
Author

sastels commented Mar 27, 2024

PR to remove queues from api / celery
cds-snc/notification-api#2148

@sastels sastels changed the title Check Oct 25th on email, sms queue usage clean up unused email / sms delivery queues Mar 27, 2024
@P0NDER0SA
Copy link

There's a PR that needs eyes on it to review and get merged. Steve will send us a notice

@sastels
Copy link
Author

sastels commented Mar 27, 2024

Corresponding terraform PR!
cds-snc/notification-terraform#1230

@sastels
Copy link
Author

sastels commented Apr 2, 2024

Also have to delete alarms from the google sheet

@sastels
Copy link
Author

sastels commented Apr 3, 2024

merged into staging yesterday. Tested with all priorities and on api and admin

@jimleroyer jimleroyer assigned ben851 and unassigned sastels Apr 3, 2024
@sastels
Copy link
Author

sastels commented Apr 4, 2024

in production

@ben851
Copy link
Contributor

ben851 commented Apr 4, 2024

Sent emails in both staging and prod in all 3 queues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants