Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move email delivery into their own dedicated queues #206

Closed
5 tasks done
sastels opened this issue Oct 10, 2023 · 7 comments
Closed
5 tasks done

Move email delivery into their own dedicated queues #206

sastels opened this issue Oct 10, 2023 · 7 comments
Assignees
Labels
Throughput Will boost our throughput

Comments

@sastels
Copy link

sastels commented Oct 10, 2023

Description

As a Notify developer, I need email delivery tasks to be in their own queues so that I can treat them differently than other tasks (ex database, callbacks).

WHY are we building?

Moving email delivery to their own queues will allow us to scale up email delivery without scaling up other tasks such as database operations or callback processing. This will also allow better monitoring and alarming for email delivery issues.

WHAT are we building?

Move email delivery tasks to their own dedicated celery queues. Note that this task does not include moving the email delivery tasks to their own dedicated pool of celery workers.

VALUE created by our solution

We will be able to scale up email delivery without scaling up other parts of the system.

Acceptance Criteria

  • deliver_email() tasks go through their own celery queues.
  • wait time alarms for the new queues created
  • charts monitoring the new queues added to the email dashboard

QA Steps

  • verify that smoke tests still pass
  • Verify that the new queues are being used with a cloudwatch query such as this one
@sastels sastels added the Throughput Will boost our throughput label Oct 10, 2023
@sastels sastels self-assigned this Oct 10, 2023
@sastels sastels changed the title Copy of Move SMS into their own dedicated queues Move email delivery into their own dedicated queues Oct 10, 2023
@sastels
Copy link
Author

sastels commented Oct 10, 2023

PR to use the new queues in celery:
cds-snc/notification-api#1997

@sastels
Copy link
Author

sastels commented Oct 10, 2023

PR to add alarms for the new queues
cds-snc/notification-terraform#962

@sastels
Copy link
Author

sastels commented Oct 10, 2023

PR to add the queues to the email dashboard
cds-snc/notification-terraform#963

@sastels
Copy link
Author

sastels commented Oct 13, 2023

These PRs can wait to be merged / released after I'm back (Oct 23)

@ben851
Copy link
Contributor

ben851 commented Oct 25, 2023

Jimmy approved and improved the PRs!

To be merged today after am release

@sastels
Copy link
Author

sastels commented Oct 31, 2023

in production

@jimleroyer
Copy link
Member

Looks like it's working 👍

Private Zenhub Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Throughput Will boost our throughput
Projects
None yet
Development

No branches or pull requests

3 participants