From d8799ac4813aec0a6afcc41a77c1d1268b0d7018 Mon Sep 17 00:00:00 2001 From: wbanks Date: Mon, 17 Jun 2024 15:53:07 -0400 Subject: [PATCH] Chore: logic cleanup --- app/dao/template_categories_dao.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/app/dao/template_categories_dao.py b/app/dao/template_categories_dao.py index 80b2b54490..367c90c6e1 100644 --- a/app/dao/template_categories_dao.py +++ b/app/dao/template_categories_dao.py @@ -9,6 +9,12 @@ from app.models import Template, TemplateCategory +DEFAULT_TEMPLATE_CATEGORIES = { + 'bulk': current_app.config['DEFAULT_TEMPLATE_CATEGORY_LOW'], + 'normal': current_app.config['DEFAULT_TEMPLATE_CATEGORY_MEDIUM'], + 'priority': current_app.config['DEFAULT_TEMPLATE_CATEGORY_HIGH'] +} + @transactional def dao_create_template_category(template_category: TemplateCategory): template_category.id = uuid.uuid4() @@ -58,7 +64,9 @@ def dao_delete_template_category_by_id(template_category_id, cascade = False): try: for template in templates: process_type = template_category.sms_process_type if template.template_type == 'sms' else template_category.email_process_type - template.category = dao_get_template_category_by_id(_get_default_category_id(process_type)) + default_category_id = DEFAULT_TEMPLATE_CATEGORIES.get(process_type, current_app.config['DEFAULT_TEMPLATE_CATEGORY_LOW']) + template.category = dao_get_template_category_by_id(default_category_id) + db.session.add(template) db.session.delete(template_category) @@ -69,11 +77,3 @@ def dao_delete_template_category_by_id(template_category_id, cascade = False): db.session.delete(template_category) db.session.commit() - -def _get_default_category_id(process_type): - default_categories = { - 'bulk': current_app.config['DEFAULT_TEMPLATE_CATEGORY_LOW'], - 'normal': current_app.config['DEFAULT_TEMPLATE_CATEGORY_MEDIUM'], - 'priority': current_app.config['DEFAULT_TEMPLATE_CATEGORY_HIGH'] - } - return default_categories.get(process_type, current_app.config['DEFAULT_TEMPLATE_CATEGORY_LOW'])