From 19044428b1f39db56c5cb0edb8204863dd71b6cd Mon Sep 17 00:00:00 2001
From: Jimmy Royer <jimleroyer@gmail.com>
Date: Thu, 9 Nov 2023 17:12:50 -0500
Subject: [PATCH] Moved celery task time execution log to DEBUG, sending as
 statsd metrics

---
 app/celery/celery.py         | 13 ++++++++++---
 app/celery/provider_tasks.py |  2 +-
 2 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/app/celery/celery.py b/app/celery/celery.py
index 6b922f81c7..3c4948497b 100644
--- a/app/celery/celery.py
+++ b/app/celery/celery.py
@@ -12,13 +12,20 @@ def worker_process_shutdown(sender, signal, pid, exitcode, **kwargs):
 
 
 def make_task(app):
+
+    from app import statsd_client
+
     class NotifyTask(Task):
         abstract = True
         start = None
 
         def on_success(self, retval, task_id, args, kwargs):
-            elapsed_time = time.time() - self.start
-            app.logger.debug("{task_name} took {time}".format(task_name=self.name, time="{0:.4f}".format(elapsed_time)))
+            task_name: str = self.name
+            now: float = time.time()
+            statsd_client.timing_with_dates(f"celery-task.{task_name}.total-time", now, self.start)
+
+            elapsed_time = now - self.start
+            app.logger.debug("{task_name} took {time}".format(task_name=task_name, time="{0:.4f}".format(elapsed_time)))
 
         def on_failure(self, exc, task_id, args, kwargs, einfo):
             # ensure task will log exceptions to correct handlers
@@ -28,7 +35,7 @@ def on_failure(self, exc, task_id, args, kwargs, einfo):
         def __call__(self, *args, **kwargs):
             # ensure task has flask context to access config, logger, etc
             with app.app_context():
-                self.start = time.time()
+                self.start: float = time.time()
                 return super().__call__(*args, **kwargs)
 
     return NotifyTask
diff --git a/app/celery/provider_tasks.py b/app/celery/provider_tasks.py
index bfdc671a2e..f150bb2b5e 100644
--- a/app/celery/provider_tasks.py
+++ b/app/celery/provider_tasks.py
@@ -63,7 +63,7 @@ def deliver_sms(self, notification_id):
 @statsd(namespace="tasks")
 def deliver_email(self, notification_id):
     try:
-        current_app.logger.info("Start sending email for notification id: {}".format(notification_id))
+        current_app.logger.debug("Start sending email for notification id: {}".format(notification_id))
         notification = notifications_dao.get_notification_by_id(notification_id)
         if not notification:
             raise NoResultFound()