diff --git a/app/celery/process_pinpoint_receipts_tasks.py b/app/celery/process_pinpoint_receipts_tasks.py index 7fe5aaf6a3..99c849ff30 100644 --- a/app/celery/process_pinpoint_receipts_tasks.py +++ b/app/celery/process_pinpoint_receipts_tasks.py @@ -97,12 +97,12 @@ def process_pinpoint_results(self, response): f"Pinpoint callback return status of {notification_status} for notification: {notification.id}" ) - statsd_client.incr(f"callback.sns.{notification_status}") # TODO: do we want a Pinpoint metric here? + statsd_client.incr(f"callback.pinpoint.{notification_status}") if notification.sent_at: statsd_client.timing_with_dates( - "callback.sns.elapsed-time", datetime.utcnow(), notification.sent_at - ) # TODO: do we want a Pinpoint metric here? + "callback.pinpoint.elapsed-time", datetime.utcnow(), notification.sent_at + ) _check_and_queue_callback_task(notification) diff --git a/tests/app/celery/test_process_pinpoint_receipts_tasks.py b/tests/app/celery/test_process_pinpoint_receipts_tasks.py index e60180a0c9..fe0f0ff29a 100644 --- a/tests/app/celery/test_process_pinpoint_receipts_tasks.py +++ b/tests/app/celery/test_process_pinpoint_receipts_tasks.py @@ -184,8 +184,8 @@ def test_process_pinpoint_results_calls_service_callback(sample_template, notify assert process_pinpoint_results(pinpoint_success_callback(reference="ref")) assert get_notification_by_id(notification.id).status == NOTIFICATION_DELIVERED assert get_notification_by_id(notification.id).provider_response == "Message has been accepted by phone" - statsd_client.timing_with_dates.assert_any_call("callback.sns.elapsed-time", datetime.utcnow(), notification.sent_at) - statsd_client.incr.assert_any_call("callback.sns.delivered") + statsd_client.timing_with_dates.assert_any_call("callback.pinpoint.elapsed-time", datetime.utcnow(), notification.sent_at) + statsd_client.incr.assert_any_call("callback.pinpoint.delivered") updated_notification = get_notification_by_id(notification.id) signed_data = create_delivery_status_callback_data(updated_notification, callback_api) send_mock.assert_called_once_with([str(notification.id), signed_data], queue="service-callbacks")