From 1567b1b6aa3ba1e68b94f4a4cd5e9f01f83a94fb Mon Sep 17 00:00:00 2001
From: MARCHAND MANON <manonmarchand22@gmail.com>
Date: Thu, 2 May 2024 11:34:08 +0200
Subject: [PATCH] use jlpm to manage playwright/galata

---
 .github/workflows/js-tests.yml | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/.github/workflows/js-tests.yml b/.github/workflows/js-tests.yml
index e3bc7281..15723818 100644
--- a/.github/workflows/js-tests.yml
+++ b/.github/workflows/js-tests.yml
@@ -12,24 +12,24 @@ jobs:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
         with:
-          node-version: lts/*
+          node-version: "18.x"
       - uses: actions/setup-python@v4
         with:
           python-version: "3.11"
-      - name: Install dependencies
+      - name: Install ipyaladin and jupyterlab
         run: |
-          npm install
           python -m pip install .
           python -m pip install jupyterlab
-          sudo apt install chromium-browser -y
-      - name: Install Playwright
-        run: npx playwright install --with-deps
+      # Steps inspired from github.com/jupyterlab/extension-examples/blob/main/.github/workflows/main.yml
+      - name: Test jupyterlab browser
+        run: python -m jupyterlab.browser_check
+      - name: Install Playwright/Galata
+        working-directory: ./js/ui-tests
+        env:
+          PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
+        run: jlpm install
+      - name: Install browser
+        run: jlpm playwright install chromium
+        working-directory: ./js/ui-tests
       - name: Run Playwright tests
-        run: |
-          npm run start-test-server & npx playwright test
-      - uses: actions/upload-artifact@v4
-        if: always()
-        with:
-          name: playwright-report
-          path: playwright-report/
-          retention-days: 10
+        run: jlpm playwright test