Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer zooming on the screen scaling factor instead of the fov value #202

Open
bmatthieu3 opened this issue Oct 11, 2024 · 2 comments
Open
Assignees

Comments

@bmatthieu3
Copy link
Collaborator

I think it would be more stable if the zooming directly influences the scaling factor of the screen image and not the fov which gives different scaling factors in function of the projection used. Internally aladin lite would have to compute the fov from a specific scaling factor.

@bmatthieu3 bmatthieu3 self-assigned this Oct 11, 2024
@tboch
Copy link
Collaborator

tboch commented Oct 13, 2024

Can you elaborate on this? Would that imply having the FoV value changed when changing projection?

@bmatthieu3
Copy link
Collaborator Author

bmatthieu3 commented Oct 14, 2024

No because when changing the projection we can still reset the screen scaling factor of the screen with respect to the current fov.
I noticed a delta of fov degrees (i.e. one wheel event) influences differently the screen scaling factor in function of the projection chosen (this is especially true for all sky view). It provides a different zooming effect (more or less fast) in function of the projection. It is more relevant and projection agnostic to treat the wheel events as a way to directly change the scaling factor (in the screen space) instead of the fov degrees (which is a sky quantity).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants