You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
So the current config setup in 'modifications' would fail at here. Since we take each array inside modifications and use that for the files in srcset in an img tag. IE:
Either We'd have to setup a config option for media queries and use those as our basis, make the modifications array even messier by using more arrays:
This all sounds dumb, is fragile and allows for to many easy to make errors.
Type Switching
Since intervention doesn't do webp (or jxr) we would need to pass through those images. PHP doesn't have a IMAGETYPE_WEBP like for jpg/png/gif but imagewebp exists in php 5.5+. So we'd need to fork and modify Flysystems getmimetype method which I'm not going to do right now.
Passing through those image's also negates the use of any glide modifications. This is a bag of snakes :)
So in order to do type switching with webp, jxr and jpeg2000 for example:
we need a way to reliably get the mimetype and then let those passthrough without using intervention to modify the images. This can be done without the extension so maybe tell uses... "nah brah manually build that baaad thang instead".
Soooo this issue here is for me to come back at another time look at this and think of a better way to handle the picture element.
The text was updated successfully, but these errors were encountered:
use the picture element with a separate twig function like:
Problems with this.
The way the config is setup right now could get messy since the picture element also allows multiple files at a particular media query. ie:
So the current config setup in 'modifications' would fail at here. Since we take each array inside modifications and use that for the files in srcset in an img tag. IE:
Either We'd have to setup a config option for media queries and use those as our basis, make the modifications array even messier by using more arrays:
This all sounds dumb, is fragile and allows for to many easy to make errors.
Type Switching
Since intervention doesn't do webp (or jxr) we would need to pass through those images. PHP doesn't have a
IMAGETYPE_WEBP
like for jpg/png/gif butimagewebp
exists in php 5.5+. So we'd need to fork and modify Flysystems getmimetype method which I'm not going to do right now.Passing through those image's also negates the use of any glide modifications. This is a bag of snakes :)
So in order to do type switching with webp, jxr and jpeg2000 for example:
we need a way to reliably get the mimetype and then let those passthrough without using intervention to modify the images. This can be done without the extension so maybe tell uses... "nah brah manually build that baaad thang instead".
Soooo this issue here is for me to come back at another time look at this and think of a better way to handle the picture element.
The text was updated successfully, but these errors were encountered: