Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arm64 copies #568

Open
uncledru opened this issue Mar 15, 2024 · 1 comment · May be fixed by #570
Open

Support for arm64 copies #568

uncledru opened this issue Mar 15, 2024 · 1 comment · May be fixed by #570
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@uncledru
Copy link

uncledru commented Mar 15, 2024

I am attempting to copy an arm64 image from one source to another and get an error:

sending status failed: copy image failed: choosing an image from manifest list docker://xxx.dkr.ecr.us-east-1.amazonaws.com/repo:latest: no image found in image index for architecture amd64, variant "", OS linux

I've attempted to set the GOARCH environment variable but that doesn't seem to help.

Nothing in the copy pkg docs stand out: https://pkg.go.dev/github.com/containers/image/v5/copy

Any suggestions? Do we need to build the customer resource with an arm64 architecture?

Edit:

Seems this is what we need - https://pkg.go.dev/github.com/containers/image/[email protected]/types#SystemContext

image

We can set this based on the env var set in the lambda GOARCH

https://github.com/cdklabs/cdk-ecr-deployment/blob/main/lambda/main.go#L106

@uncledru
Copy link
Author

I see this is open #364

@wchaws is this the right approach? I can open another PR with similar changes if needed

@mrgrain mrgrain added enhancement New feature or request help wanted Extra attention is needed labels Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants