Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Assertion Refinement tools to MQT Debugger #35

Merged
merged 35 commits into from
Dec 5, 2024
Merged

✨ Add Assertion Refinement tools to MQT Debugger #35

merged 35 commits into from
Dec 5, 2024

Conversation

DRovara
Copy link
Collaborator

@DRovara DRovara commented Nov 20, 2024 •
edited
Loading

Description

This pull request adds all assertion refinement features discussed in the new assertion refinement paper to the
MQT Debugger.

This includes:

  • Moving Assertions:
    • Defines a set of commutation rules that allow assertions to be moved
  • Creating Assertions:
    • Uses interaction graph methods to add new entanglement assertions
    • Splits larger entanglement and equality assertions into smaller ones

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

DRovara and others added 28 commits October 10, 2024 14:17
@DRovara
feat: ✨ Define basic commutation rules for general assertions
1e3fea1
@DRovara
feat: ✨ Add some more commutation rule
d68d5a2
@DRovara
feat: ✨ Add assertion movement functionality to Diagnostics
1468dc0
@DRovara
test: ✅ Refactor test structure and add new tests for assertion movement
a631c3e
@DRovara
refactor(assertion-tools): ♻️ Change passing mode to reference for te…
9e285d5 
…sting assertion movements
@DRovara
ci(assertion-tools): 👷 Add assertion-tools branch to ci
80b3128
@DRovara
test(assertion-tools): ✅ Add new assertion movement tests
845451a
@DRovara
feat(assertion-tools): ✨ Add entanglement-assertion creation tools an…
e4c9046 
…d tests
@DRovara
refactor(assertion-tools): ♻️ Fix some linting issues
7f321d8
@DRovara
refactor(assertion-tools): ♻️ Update the commutativity rule logic
14412e4
@DRovara
refactor(assertion-tools): ♻️ Refactor commutativity rule logic
3e673cd
@DRovara
test(assertion-tools): ✅ Add new tests and fix some minor issues
2fd11d3
@DRovara
feat(assertion-tools): ✨ Add assertion suggestion to CLI Frontend
f5b30b0
@DRovara
test(assertion-tools): 🧪 Add tests for new equality assertion splitti…
e604fc6 
…ng method
@DRovara
style(assertion-tools): ♻️ Fix pre-commit issues
671834c
@DRovara
refactor(assertion-tools): ♻️ Refactor maths methods from DDSimDebug …
4db7fea 
…into a common maths file
@DRovara
feat(assertion-tools): :feat: Add equality assertion splitting method
61e4e0f
@DRovara
build(assertion-tools): ⬆️ Change python version for bindings to 3.9
166ccf0
@DRovara
fix: 🐛 Fix parsing of negative complex numbers
083610f
@DRovara
feat(assertion-tools): :feat: Allow moving assertions over other asse…
bace1dc 
…rtions

This has to be allowed, otherwise one stuck assertion would block all others. Later on, some changes should be made to ensure the sorting remains stable
@DRovara
feat(assertion-tools): ✨ Calling the assertion-tool methods with coun…
137fba5 
…t 0 now returns the maximum size
@DRovara
feat(assertion-tools): ✨ Implement get quantum variable name method
a57a86f
@DRovara
refactor(assertion-tools): ♻️ Increase epsilon when computing entangl…
032a2d4 
…ement (it's better to be more lenient)
@DRovara
build(assertion-tools): 🏗️ Update python bindings
25d9a3d
@DRovara
test(assertion-tools): ✅ Add test for assertion creation of eq assert…
7d5d48d 
…ions
@DRovara
feat(assertion-tools): :feat: Stop ent-assertion generation when conn…
36124df 
…ection is not unique
@DRovara
feat(assertion-tools): :feat: Ent-Assertion creation now builds 1:1 a…
b9b3413 
…long the path instead of 1:n from the base
@DRovara
test(assertion-tools): 🧪 Remove assertion movement test that requires…
9c14b24 
… stable sorting
@DRovara DRovara linked an issue Nov 20, 2024 that may be closed by this pull request
🐛 Classically Controlled Gates cause Issues #29
Closed
@DRovara DRovara self-assigned this Nov 20, 2024
@DRovara DRovara added enhancement New feature or request c++ labels Nov 20, 2024
@DRovara DRovara merged commit 86627d5 into main Dec 5, 2024
25 checks passed
@DRovara DRovara deleted the assertion-tools branch December 5, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DRovara DRovara

Labels
c++ enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Classically Controlled Gates cause Issues
1 participant
@DRovara