-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diffusive Mixing (1D <--> CFD) #50
base: main
Are you sure you want to change the base?
Conversation
The resolution for the calculation of diffusion using an analytical solution including a fourier series is renamed to numFourierTerms and set as a private variable in the DiffusionMixingModel. It is set to ```int numFourierTerms = 100;``` It can be adapted using ```resetNumFourierTerms(int newNumFourierTerms)``` This solves Issue #43
@micheltakken I have added the connection between the abstract diffusive mixing to and from the CFD Modules.
For both cases we adhere to the law of mass conservation. The connection "on the CFD side" is still missing. Once we have included the missing parts we can start to test. |
src/simulation/MixingModels.hh
Outdated
// auto& section = outflowDistributions.at(channel->getId()).front(); // there is only one channel connected to a node at a CFD hybrid node connection | ||
// // std::vector<T> inflowSectionIntoCfd = section.concentrationField; | ||
// } | ||
int resolutionIntoCfd = 20; // TODO this should be a parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the lattice resolution is hard coded rather than passed from the simulator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resolution values are stored in olbContinuous.h or essContinuous.h and can technically be obtained from a cfdSimulator with cfdSimulator->getResolution()
. This is not yet implemented. I will take care of this.
TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the getResolution(nodeId) function and a TODO in the olbMixing.hh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the comments for the resuested changes
They are mainly concerning residual(?) or missing comments in the code.
Apart from that it looks good, and good first iteration using GitHub :)
…ntration profiles.
This only works if the resolution, i.e., the number of lattice points at the node, does not change during the simulation (at different timesteps)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO @ self
Define the coupling of Abstract and CFD from the CFD part
This PR updates
The connection of the CFD Module and 1D diffusive mixing, concentrations are passed as concentration fields to the CFD Module and concentration fields are translated as linear segments as input for the 1D diffusive mixing.
PR Checklist