Run CMake CI build/tests on Windows #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndevenish
force-pushed
the
windows_cmake
branch
3 times, most recently
from
71d03fd to
3657105
Compare
ndevenish
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
ndevenish
force-pushed
the
windows_cmake
branch
from
3657105 to
35c7e7c
Compare
toastisme
pushed a commit
to toastisme/dxtbx
that referenced
this pull request
Jul 18, 2024
And update CCTBX prebuilt base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(To merge after #607)
This updates prebuilt cctbx, and adds Windows to the platforms run by the azure CI. This was previously impossible due to conda-forge/cctbx-base-feedstock#28, and apparently still causing problems as of #396. Using the CMake build for windows (as well as mac and linux, which already use it) neatly sidesteps the issue.
Windows being the only platform missing has occasionally caused issues through things breaking on the windows build. c2706ed, ec97f03 and #607 were explicitly identified as things that were currently breaking, and have been fixed. We should endeavour to have a full-regression-suite running also.
Fixes #396.