Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

on ebay list, selecting a new page number on filtered search results loses filter and returns full category #17

Open
cbmarcum opened this issue Dec 28, 2016 · 4 comments
Open

on ebay list, selecting a new page number on filtered search results loses filter and returns full category #17

cbmarcum opened this issue Dec 28, 2016 · 4 comments
Assignees
@cbmarcum

Comments

@cbmarcum
Copy link
Owner

cbmarcum commented Dec 28, 2016 •
edited
Loading

Problem 1. Selecting a new page on a search filtered list looses the search filter.
Problem 2, Performing a search while on an advanced page (2, 3, 4, etc) starts the offset where it was on the unfiltered data instead of resetting to 0.
Problem 3. an empty search throws an error.
@cbmarcum
Copy link
Owner Author

URL is missing &keywords=searchterm

@cbmarcum
Copy link
Owner Author

A new search also needs to reset pagination offset to 0.

@cbmarcum
Copy link
Owner Author

A blank search throws an error.

@cbmarcum cbmarcum self-assigned this Jan 11, 2020
cbmarcum added a commit that referenced this issue Feb 2, 2020
@cbmarcum
Refs #17 - fix for ebay listing issues.
221bb55 
ebay/index view: added index and removed list view per convention.
Ebay controller: removed store, list, and search actions and chaining and created new index action for both list and search types similar to product controller.
EbayTagLib: added keywords to link params.
ebay/_menubar-search template: changed action to index, added height to text field to match button. changed button style to primary and changed icon to match product search.
product/_menubar-search template: added height to text field to match button.
build.gradle: updated app version.
@cbmarcum
Copy link
Owner Author

cbmarcum commented Feb 8, 2020

Fixed in 3.3.16 branch. copy from there.

@cbmarcum cbmarcum mentioned this issue Feb 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbmarcum cbmarcum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cbmarcum