-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: add trials to metadata #997
Comments
We currently have an Excel and Csv reader for trials, but those are rarely used. Anyway, I like the idea of being able to pass the data to an interface in-memory, since we often are reading this data from esoteric .mat files and other types of formats where the data reading step is very user-specific. I can see two options here
Since this doesn't really even require an init, we could even make it a class method, so you could do:
Then if you use an NWBConverter or a ConverterPipe and your metadata contains a trials table, we could automatically add I think I'm leaning towards option 2. |
I also vote for number 2. |
For now I just decided to improve the docs to show how to add trials with PyNWB. I think this is basically the same amount of effort as adding metadata, so I don't think we gain much here by adding an interface. Then theres the question of the NWB GUIDE. Having an interface could be helpful there, but we instead might just want to go a completely different direction and just have a dedicated page with dedicated logic for adding trials. |
Should we close this issue? I rather close issues once they get to a somehow logical conclussion but I don't know how you prefer to handle this. I am asking to take this into account going into the future. |
yeah, sounds good |
What would you like to see added to NeuroConv?
I would like to be able to add a "trials" field to metadata and have it automatically write a trials table to the NWB file.
Is your feature request related to a problem?
I saw the following exchange on the new chatbot:
bot:
user:
bot:
user:
bot:
This is not accurate. But honestly, I think it's a good idea, and it wouldn't be hard to implement.
Do you have any interest in helping implement the feature?
Yes.
Code of Conduct
The text was updated successfully, but these errors were encountered: