Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy burst is orphaned, needs to be phased out from mods #5735

Open
RoyalFox2140 opened this issue Nov 18, 2024 · 1 comment
Open

legacy burst is orphaned, needs to be phased out from mods #5735

RoyalFox2140 opened this issue Nov 18, 2024 · 1 comment
Labels
bug confirmed Bug that has been reproduced JSON related to game datas in JSON format. mods PR changes related to mods. src changes related to source code.

Comments

@RoyalFox2140
Copy link
Collaborator

Describe the bug

After #5734 burst is orphaned. It needs removal, but mods use it. It needs a period of warning messages to isolate the mods that still use it.

You can use fire modes instead, it's much better.

Steps To Reproduce

check the code

Screenshots

No response

Versions and configuration

All

Additional context

No response

@RoyalFox2140 RoyalFox2140 added bug confirmed Bug that has been reproduced src changes related to source code. mods PR changes related to mods. JSON related to game datas in JSON format. labels Nov 18, 2024
@scarf005
Copy link
Member

image

https://github.com/search?q=LANGUAGE%3Ajson+%2F"type"%3A+"GUN"(.|\n)*"burst"%3A%2F&type=code

there's lots of false positives (i.e DDA mods, DDA and BN forks) but looks like there's still some usage outside kenan's

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed Bug that has been reproduced JSON related to game datas in JSON format. mods PR changes related to mods. src changes related to source code.
Projects
None yet
Development

No branches or pull requests

2 participants