Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ammonia, Bleach, Lye etc from eat/drink menu #5701

Open
narkiel opened this issue Nov 12, 2024 · 11 comments
Open

Remove Ammonia, Bleach, Lye etc from eat/drink menu #5701

narkiel opened this issue Nov 12, 2024 · 11 comments
Labels
bug confirmed Bug that has been reproduced easy Simple task that doesn't require understanding the code much JSON related to game datas in JSON format.

Comments

@narkiel
Copy link

narkiel commented Nov 12, 2024

Is your feature request related to a problem? Please describe.

There is no reason anyone would ever want to drink bleach etc. At best, it's a roundabout redundant method for shift+Q. Having them be drinkable just adds an unnecessary and unfun landmine to the eat/drink menu.

Describe the solution you'd like

Remove the ability to eat/drink bleach, ammonia, lye, and any similar chemicals I may have be forgetting.

Additional context

No response

@blot-runner
Copy link
Contributor

As a player who just drank raw mutant blood by accident, all I can say is: YES. YES, PLEASE.

@AskaHope
Copy link

Add a flag like hazardous or something and remove those among other drugs from the "E" menu, they should be "a" only.

@narkiel
Copy link
Author

narkiel commented Nov 13, 2024 via email

@blot-runner
Copy link
Contributor

blot-runner commented Nov 13, 2024

Actually now that you mention it, there's already a flag to exclude dangerous substances from auto eat zones. We could potentially reuse that, although it would also exclude things like alcohol.

Why not just change the type from COMESTIBLES into AMMO (with ammo_type: "components")? This'll exclude it from the list of edible things completely.
For the record: this is exactly how salt water is coded in jsons.

@Proxiehunter
Copy link

Proxiehunter commented Nov 14, 2024

Actually now that you mention it, there's already a flag to exclude dangerous substances from auto eat zones.

Not an expert but I'm pretty sure that doesn't prevent them from being (E)aten through the eat menu which is what @narkiel is talking about. And I'm pretty sure bleach, ammonia, etc. are already excluded from auto eat zones or people would be accidentally drinking bleach more often.

@blot-runner

Why not just change the type from COMESTIBLES into AMMO (with ammo_type: "components")? This'll exclude it from the list of edible things completely. For the record: this is exactly how salt water is coded in jsons.

You know, I thought plant mutants had a thing where they could eat fertilizer and I wasn't sure how ammonia interacted with that but I'm not seeing it when I look at plant mutants on the Hitchhikers Guide to the Cataclysm Bright Nights Version. Maybe that was removed or was from DDA. Still I'm not sure how doing that would interact with mutagen which generally uses bleach and ammonia or lye powder. Can you use non-comestibles as a component of a comestible?

@blot-runner
Copy link
Contributor

blot-runner commented Nov 14, 2024

Can you use non-comestibles as a component of a comestible?

Yes, at least, as far as I can see. For example, salt water (non-comestible) is used as a component for crafting bleach (at present a comestible).

@Ignaramico
Copy link

doesnt eating that kind of stuff prompt a warning?,
and iirc in the earliers days of CDDA forum was a list of challenges and one of them was surviving eating a gallon of bleach (among other ones) lol :x,

@blot-runner
Copy link
Contributor

doesnt eating that kind of stuff prompt a warning?,

As a matter of fact, it does, for both bleach and ammonia. Ditto for liquid fertilizer and sewage sample, but not for vodka, which also has UNSAFE_CONSUME flag. IDK, maybe that's enough of a safeguard?
By the way, lye is listed as a possible food, but I was unable to drink it, choosing the entry simply does nothing. Talk about disturbing topic for a bug report))

@RoyalFox2140 RoyalFox2140 added bug easy Simple task that doesn't require understanding the code much confirmed Bug that has been reproduced JSON related to game datas in JSON format. and removed enhancement labels Nov 14, 2024
@RoyalFox2140
Copy link
Collaborator

As another source of YASD we don't want drinkable chemicals so it's considered a bug.

@RoyalFox2140
Copy link
Collaborator

Can you use non-comestibles as a component of a comestible?

You can make oranges from dirt and transmutation runes in 2200.

@Ignaramico
Copy link

By the way, lye is listed as a possible food, but I was unable to drink it, choosing the entry simply does nothing. Talk about disturbing topic for a bug report))

wasnt that the same issue with paper and other stuff(like seeds irrc)? being listed as food on the eat menu but not able to eat it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed Bug that has been reproduced easy Simple task that doesn't require understanding the code much JSON related to game datas in JSON format.
Projects
None yet
Development

No branches or pull requests

6 participants