Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct minor gramatical error in description of Large Wooden Shield #5680

Open
Proxiehunter opened this issue Nov 7, 2024 · 5 comments
Open
Labels
confirmed Bug that has been reproduced easy Simple task that doesn't require understanding the code much JSON related to game datas in JSON format.

Comments

@Proxiehunter
Copy link

Is your feature request related to a problem? Please describe.

No response

Describe the solution you'd like

Large Wooden Shield is described as "An crude wooden tower shield". Grammatically should be "A crude wooden tower shield."

Additional context

No response

@scarf005 scarf005 added easy Simple task that doesn't require understanding the code much and removed enhancement labels Nov 8, 2024
@scarf005
Copy link
Member

scarf005 commented Nov 8, 2024

could you please open a PR?

@ZChris13
Copy link

could you please open a PR?

is there a tutorial for this, I have some petty grammar fixes to suggest as well

@scarf005
Copy link
Member

could you please open a PR?

is there a tutorial for this, I have some petty grammar fixes to suggest as well

https://docs.cataclysmbn.org/en/contribute/contributing/

@RoyalFox2140 RoyalFox2140 added confirmed Bug that has been reproduced JSON related to game datas in JSON format. labels Nov 11, 2024
@Proxiehunter
Copy link
Author

could you please open a PR?

is there a tutorial for this, I have some petty grammar fixes to suggest as well

https://docs.cataclysmbn.org/en/contribute/contributing/

Thanks for the link. Having looked at other people's PR's the process of making one looked quite complicated for someone who's main interaction with github has been limited to downloading files and reporting bugs. Between that and being wiped by daily activities and stressors I haven't gotten around to opening the PR for this but the link you gave gets me a step closer. Now I just need some energy and ability to concentrate.

@scarf005
Copy link
Member

it' really easy, it's as simple as searching https://github.com/cataclysmbnteam/Cataclysm-BN/blob/main/data/json/items/armor/shields.json and clicking edit this file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Bug that has been reproduced easy Simple task that doesn't require understanding the code much JSON related to game datas in JSON format.
Projects
None yet
Development

No branches or pull requests

4 participants