Confidence of negative assertions

[woodkri]

In List View, negative assertions from the VLRC show up with confidence of NaN%.

[Lomilar]

Negative assertions from the VLRC now have confidence. Up to you @woodkri or @whistlinjoe if you want NaN% behavior to be different.

[woodkri]

From a user perspective, I think NaN would be confusing to people who don't have a background in tech. Maybe it could display n/a like you see if you click on it? Or could just be a blank circle if there's not a number associated with the confidence.

I also just noticed it appears in the graph view as well.

[whistlinjoe]

Can either @woodkri or @Lomilar send me the URL for an assertion you are using to generate the NaN? I'm using these and it seems to work fine.
Assertion 1 (with mixed positive and negative assertions):
https://sandbox.cassproject.org/api/data/schema.cassproject.org.0.3.Assertion/2d18762e-bb8f-488c-8ff8-1989439d791d

Graph View Details:

List View:

Confidence Details:

Assertion 2 (Single negative assertion (88% confidence) - leads to negative confidence which should be fine for calculations):

https://sandbox.cassproject.org/api/data/schema.cassproject.org.0.3.Assertion/0e3dc888-e0fb-402e-a221-140085e352a1

Graph View Details:

List View:

Confidence Details:

UI probably needs a correction in the assertion details. At first glance it appears that a negative assertion has positive confidence.

Edit: This also brings up a question of how we should display things that are clearly in the negative (Like Oracle would be with assertion two). At first glance it would appear the profile target actually holds the competency. (created a new issue for this: #19)

[woodkri]

@whistlinjoe Here's an example of the confidence details:

Do you have a profile on the dev server? I can try sharing one with you there if that's helpful. These assertions were created in the VLRC but I'm guessing the same issue would occur anytime there's no confidence defined.

[whistlinjoe]

@woodkri So the problem isn't "negative assertions from the VLRC show up with confidence of NaN%." it's that assertions with no confidence show up as NaN?

[whistlinjoe]

I corrected the display issue but leaving this open for now. I can't repro the error so I'm not sure what is going to happen. @woodkri is helping troubleshoot. The only way I can see this happening is if the confidence field is totally missing from the assertion record (we viewed that happening in @woodkri test data). The last I was aware, confidence was a required field for assertions and you would receive a "Failing to save: Confidence cannot be missing" error if you tried to save an assertion without that value. Any input @Lomilar ?

[Lomilar]

Generally, with linked data (see schema.org for instance), cardinality and whether something is required are specifically not specified, we follow this same pattern. All forms of a piece of data are valid, but some are more useful than others, and some are quite useless.

[whistlinjoe]

Closing this for now and opening up issue for displaying explicitly unheld competencies #19