Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor builders to ensure they are not exposed in public crates #4986

Closed
2 tasks done
devendran-m opened this issue Nov 27, 2024 · 2 comments · Fixed by #4989
Closed
2 tasks done

Refactor builders to ensure they are not exposed in public crates #4986

devendran-m opened this issue Nov 27, 2024 · 2 comments · Fixed by #4989
Assignees
@zajko
Labels
rc-5 Release Candidate 5

Comments

@devendran-m
Copy link
Contributor

devendran-m commented Nov 27, 2024 •
edited
Loading

Builders (e.g., TransactionBuilder, DeployBuilder, GenesisConfigBuilder) are exposed in public crates (Casper Types), leading to potential stability issues.

To Do:

  • Ticket to refactor to ensure builders are marked for internal/test use only.
  • Move GenesisConfigBuilder to EE test crate.
@devendran-m devendran-m added the rc-5 Release Candidate 5 label Dec 2, 2024
@devendran-m
Copy link
Contributor Author

Per the planning discussion with @zajko , this is considered as a critical one for the release.

@devendran-m devendran-m linked a pull request Dec 3, 2024 that will close this issue
Removing builder structs from public API of casper-types #4989
Merged
@devendran-m
Copy link
Contributor Author

Resolved by the PR #4989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zajko zajko

Labels
rc-5 Release Candidate 5
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing builder structs from public API of casper-types zajko/casper-node
4 participants
@zajko @devendran-m @darthsiroftardis @EdHastingsCasperAssociation