Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createRandomSecp256k1Key returns a null key #199

Closed
cnorburn opened this issue Jun 13, 2023 · 3 comments · Fixed by #264
Closed

createRandomSecp256k1Key returns a null key #199

cnorburn opened this issue Jun 13, 2023 · 3 comments · Fixed by #264
Assignees
@AB3rtz
Labels
bug Something isn't working

Comments

@cnorburn
Copy link
Collaborator

Code located in the CasperKeyHelper
@cnorburn cnorburn added the bug Something isn't working label Jun 13, 2023
@meywood
Copy link
Collaborator

meywood commented Mar 13, 2024

The key for Secp256k1Key is a big integer so really would need a big refactor perhaps with generics. In the mean time the secp256k1PrivateKey.getKeyPair().getPrivateKey() should be used.

@meywood
Copy link
Collaborator

meywood commented Mar 19, 2024

Will be resolved once PR against PR syntifi/crypto-keys#12 is approved and merged

@meywood
Copy link
Collaborator

meywood commented Apr 15, 2024

Closed in issues/63

@meywood meywood closed this as completed Apr 15, 2024
@meywood meywood linked a pull request Apr 15, 2024 that will close this issue
Issues/263 - Merge in com.syntifi.crypto sources #264
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AB3rtz AB3rtz

Labels
bug Something isn't working
Projects
Work In Progress
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issues/263 - Merge in com.syntifi.crypto sources casper-network/casper-java-sdk
3 participants
@cnorburn @AB3rtz @meywood