Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing TransactionV1 structure follwing https://github.com/casper-network/casper-node/pull/4890 #191

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Changing TransactionV1 structure follwing https://github.com/casper-network/casper-node/pull/4890 #191

merged 8 commits into from
Oct 17, 2024

Conversation

gRoussac
Copy link
Contributor

@gRoussac gRoussac commented Oct 7, 2024 •
edited
Loading

Porting the changes required to compile the client and run tests with changes of

Changing TransactionV1 structure follwing #4890

  • Adding additional_computation_factor in TransactionStrParams for "Fixed" Pricing mode

  • Replace Transaction Category by is_install_upgrade in session::run and TransactionBuilderParams::Session following TransactionTarget::Session

  • Change tests / Add some tests for additional_computation_factor

Please note new format of a generated transaction

{
  "hash": "864b384f3c5e45070d0f9aa66b6ccb41406521b81346ada017b3900eb404d75c",
  "payload": {
    "initiator_addr": {
      "PublicKey": "01722e1b3d31bef0ba832121bd2941aae6a246d0d05ac95aa16dd587cc5469871d"
    },
    "timestamp": "2024-10-07T16:59:42.023Z",
    "ttl": "30m",
    "chain_name": "test",
    "pricing_mode": {
      "Fixed": {
        "additional_computation_factor": 0,
        "gas_price_tolerance": 10
      }
    },
    "fields": {
      "0": "020000000600000074617267657421000000722e1b3d31bef0ba832121bd2941aae6a246d0d05ac95aa16dd587cc5469871d010c06000000616d6f756e7402000000010a08",
      "1": "010000000000000000000100000000",
      "2": "010000000000000000000100000002",
      "3": "010000000000000000000100000000"
    }
  },
  "approvals": []
}

@gRoussac gRoussac requested review from zajko and devendran-m October 7, 2024 17:04
@gRoussac
Copy link
Contributor Author

gRoussac commented Oct 7, 2024

CI/CD will pass once #4890 is merged on dev branch

@gRoussac gRoussac requested a review from jeffkarau October 7, 2024 17:07
@gRoussac gRoussac linked an issue Oct 8, 2024 that may be closed by this pull request
Canonical Transaction update on the client #192
Open
@gRoussac gRoussac changed the title Changing TransactionV1 structure follwing https://github.com/casper-network/casper-node/pull/4890/commits Changing TransactionV1 structure follwing https://github.com/casper-network/casper-node/pull/4890 Oct 17, 2024
@gRoussac
Update json-schema
c126b8d
@gRoussac
Merge branch 'feat-track-node-2.0' of github.com:casper-ecosystem/cas…
152345b 
…per-client-rs into feat-track-node-2.0-transaction

# Conflicts:
#	Cargo.toml
@gRoussac gRoussac merged commit 99be816 into casper-ecosystem:feat-track-node-2.0 Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zajko zajko zajko approved these changes

@devendran-m devendran-m Awaiting requested review from devendran-m

@jeffkarau jeffkarau Awaiting requested review from jeffkarau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canonical Transaction update on the client
2 participants
@gRoussac @zajko